Skip to content

fix: gracefully handle invalid base64 in grpc-status-details-bin header #2578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hieuit095 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: gracefully handle invalid base64 in grpc-status-details-bin header #2578

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tonic/src/status.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,8 +476,11 @@
let details = match header_map.get(Self::GRPC_STATUS_DETAILS) {
Some(header) => crate::util::base64::STANDARD
.decode(header.as_bytes())
.expect("Invalid status header, expected base64 encoded value")
.into(),
.map(Bytes::from)
.unwrap_or_else(|_| {
warn!("error decoding grpc-status-details-bin header");
Bytes::new()
}),
None => Bytes::new(),
};

Expand Down Expand Up @@ -778,7 +781,7 @@
trailers: Option<&HeaderMap>,
status_code: http::StatusCode,
) -> Result<(), Option<Status>> {
if let Some(trailers) = trailers {

Check warning on line 784 in tonic/src/status.rs

View workflow job for this annotation

GitHub Actions / clippy 

this `if` statement can be collapsed
if let Some(status) = Status::from_header_map(trailers) {
if status.code() == Code::Ok {
return Ok(());
Expand Down
Loading