Skip to content

core: Wait for backoff timer on address update in pick_first #12678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ejona86 merged 2 commits into from
Mar 9, 2026
+6 −1
Merged

core: Wait for backoff timer on address update in pick_first #12678

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02aa9b8
core: Wait for backoff timer on address update in pick_first
ejona86 Mar 6, 2026
cad4063
Handle reconnect attempt jitter in test
ejona86 Mar 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/java/io/grpc/internal/PickFirstLeafLoadBalancer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ private void shutdownRemaining(SubchannelData activeSubchannelData) {
*/
@Override
public void requestConnection() {
if (!addressIndex.isValid() || rawConnectivityState == SHUTDOWN) {
if (!addressIndex.isValid() || rawConnectivityState == SHUTDOWN || reconnectTask != null) {
return;
}

Expand Down
5 changes: 5 additions & 0 deletions core/src/test/java/io/grpc/internal/PickFirstLeafLoadBalancerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1446,6 +1446,11 @@ public void updateAddresses_disjoint_transient_failure() {
loadBalancer.acceptResolvedAddresses(
ResolvedAddresses.newBuilder().setAddresses(newServers).setAttributes(affinity).build());

if (serializeRetries) {
inOrder.verify(mockSubchannel3, never()).start(stateListenerCaptor.capture());
forwardTimeByBackoffDelay();
}

// subchannel 3 still attempts a connection even though we stay in transient failure
assertEquals(TRANSIENT_FAILURE, loadBalancer.getConcludedConnectivityState());
inOrder.verify(mockSubchannel3).start(stateListenerCaptor.capture());
Expand Down
Loading