Support ConnectionSpec on Okhttp client and support null ConnectionSpec parameters

okhttp/src/main/java/io/grpc/okhttp/OkHttpChannelBuilder.java

@@ -176,6 +176,18 @@ public static OkHttpChannelBuilder forTarget(String target, ChannelCredentials c
     return new OkHttpChannelBuilder(target, creds, result.callCredentials, result.factory);
   }
 
+  private static ConnectionSpec connectionSpecFromChannelCredentials(ChannelCredentials channelCredentials) {
+    if (channelCredentials instanceof SslSocketFactoryChannelCredentials.ChannelCredentials) {
+      return ((SslSocketFactoryChannelCredentials.ChannelCredentials) channelCredentials).getConnectionSpec();
+    } else if (channelCredentials instanceof CompositeChannelCredentials) {
+      return connectionSpecFromChannelCredentials(
+          ((CompositeChannelCredentials) channelCredentials).getChannelCredentials()
+      );
+    } else {
+      return null;
+    }
+  }
+
   private ObjectPool<Executor> transportExecutorPool = DEFAULT_TRANSPORT_EXECUTOR_POOL;
   private ObjectPool<ScheduledExecutorService> scheduledExecutorServicePool =
       SharedResourcePool.forResource(GrpcUtil.TIMER_SERVICE);
@@ -222,6 +234,10 @@ private OkHttpChannelBuilder(String target) {
     this.negotiationType = factory == null ? NegotiationType.PLAINTEXT : NegotiationType.TLS;
     this.freezeSecurityConfiguration = true;
     this.channelCredentials = channelCreds;
+    ConnectionSpec connectionSpec = connectionSpecFromChannelCredentials(channelCreds);
+    if (connectionSpec != null) {
+      this.connectionSpec = connectionSpec;
+    }
   }
 
   private final class OkHttpChannelTransportFactoryBuilder

okhttp/src/main/java/io/grpc/okhttp/SslSocketFactoryChannelCredentials.java

@@ -18,6 +18,8 @@
 
 import com.google.common.base.Preconditions;
 import io.grpc.ExperimentalApi;
+import io.grpc.okhttp.internal.ConnectionSpec;
+
 import javax.net.ssl.SSLSocketFactory;
 
 /** A credential with full control over the SSLSocketFactory. */
@@ -29,18 +31,43 @@ public static io.grpc.ChannelCredentials create(SSLSocketFactory factory) {
     return new ChannelCredentials(factory);
   }
 
+  public static io.grpc.ChannelCredentials create(
+      SSLSocketFactory factory, com.squareup.okhttp.ConnectionSpec connectionSpec) {
+    return new ChannelCredentials(factory, Utils.convertSpec(connectionSpec));
+  }
+
+  public static io.grpc.ChannelCredentials create(
+      SSLSocketFactory factory, String[] tlsVersions, String[] cipherSuiteList, boolean supportsTlsExtensions) {
+    ConnectionSpec connectionSpec = new ConnectionSpec.Builder(true)
+        .tlsVersions(tlsVersions)
+        .cipherSuites(cipherSuiteList)
+        .supportsTlsExtensions(supportsTlsExtensions)
+        .build();
+    return new ChannelCredentials(factory, connectionSpec);
+  }
+
   // Hide implementation detail of how these credentials operate
   static final class ChannelCredentials extends io.grpc.ChannelCredentials {
     private final SSLSocketFactory factory;
+    private final ConnectionSpec connectionSpec;
 
-    private ChannelCredentials(SSLSocketFactory factory) {
+    ChannelCredentials(SSLSocketFactory factory) {
+      this(factory, OkHttpChannelBuilder.INTERNAL_DEFAULT_CONNECTION_SPEC);
+    }
+
+    ChannelCredentials(SSLSocketFactory factory, ConnectionSpec connectionSpec) {
       this.factory = Preconditions.checkNotNull(factory, "factory");
+      this.connectionSpec = Preconditions.checkNotNull(connectionSpec, "connectionSpec");
     }
 
     public SSLSocketFactory getFactory() {
       return factory;
     }
 
+    public ConnectionSpec getConnectionSpec() {
+      return connectionSpec;
+    }
+
     @Override
     public io.grpc.ChannelCredentials withoutBearerTokens() {
       return this;

okhttp/src/main/java/io/grpc/okhttp/SslSocketFactoryServerCredentials.java

@@ -35,6 +35,16 @@ public static io.grpc.ServerCredentials create(
     return new ServerCredentials(factory, Utils.convertSpec(connectionSpec));
   }
 
+  public static io.grpc.ServerCredentials create(
+      SSLSocketFactory factory, String[] tlsVersions, String[] cipherSuiteList, boolean supportsTlsExtensions) {
+    ConnectionSpec connectionSpec = new ConnectionSpec.Builder(true)
+        .tlsVersions(tlsVersions)
+        .cipherSuites(cipherSuiteList)
+        .supportsTlsExtensions(supportsTlsExtensions)
+        .build();
+    return new ServerCredentials(factory, connectionSpec);
+  }
+
   // Hide implementation detail of how these credentials operate
   static final class ServerCredentials extends io.grpc.ServerCredentials {
     private final SSLSocketFactory factory;

okhttp/src/main/java/io/grpc/okhttp/TlsServerHandshakerSocketFactory.java

@@ -26,6 +26,7 @@
 import java.io.IOException;
 import java.net.Socket;
 import java.util.Arrays;
+import java.util.Collections;
 import javax.net.ssl.SSLSocket;
 import javax.net.ssl.SSLSocketFactory;
 
@@ -58,7 +59,7 @@ public HandshakeResult handshake(Socket socket, Attributes attributes) throws IO
     String negotiatedProtocol = OkHttpProtocolNegotiator.get().negotiate(
         sslSocket,
         null,
-        connectionSpec.supportsTlsExtensions() ? Arrays.asList(expectedProtocol) : null);
+        connectionSpec.supportsTlsExtensions() ? Collections.singletonList(expectedProtocol) : null);
     if (!expectedProtocol.toString().equals(negotiatedProtocol)) {
       throw new IOException("Expected NPN/ALPN " + expectedProtocol + ": " + negotiatedProtocol);
     }

okhttp/src/main/java/io/grpc/okhttp/Utils.java

@@ -75,15 +75,25 @@ static ConnectionSpec convertSpec(com.squareup.okhttp.ConnectionSpec spec) {
     Preconditions.checkArgument(spec.isTls(), "plaintext ConnectionSpec is not accepted");
 
     List<com.squareup.okhttp.TlsVersion> tlsVersionList = spec.tlsVersions();
-    String[] tlsVersions = new String[tlsVersionList.size()];
-    for (int i = 0; i < tlsVersions.length; i++) {
-      tlsVersions[i] = tlsVersionList.get(i).javaName();
+    String[] tlsVersions;
+    if (tlsVersionList != null) {
+      tlsVersions = new String[tlsVersionList.size()];
+      for (int i = 0; i < tlsVersions.length; i++) {
+        tlsVersions[i] = tlsVersionList.get(i).javaName();
+      }
+    } else {
+      tlsVersions = null;
     }
 
     List<com.squareup.okhttp.CipherSuite> cipherSuiteList = spec.cipherSuites();
-    CipherSuite[] cipherSuites = new CipherSuite[cipherSuiteList.size()];
-    for (int i = 0; i < cipherSuites.length; i++) {
-      cipherSuites[i] = CipherSuite.valueOf(cipherSuiteList.get(i).name());
+    CipherSuite[] cipherSuites;
+    if (cipherSuiteList != null) {
+      cipherSuites = new CipherSuite[cipherSuiteList.size()];
+      for (int i = 0; i < cipherSuites.length; i++) {
+        cipherSuites[i] = CipherSuite.valueOf(cipherSuiteList.get(i).name());
+      }
+    } else {
+      cipherSuites = null;
     }
 
     return new ConnectionSpec.Builder(spec.isTls())

okhttp/third_party/okhttp/main/java/io/grpc/okhttp/internal/ConnectionSpec.java

@@ -128,7 +128,11 @@ public boolean supportsTlsExtensions() {
   public void apply(SSLSocket sslSocket, boolean isFallback) {
     ConnectionSpec specToApply = supportedSpec(sslSocket, isFallback);
 
-    sslSocket.setEnabledProtocols(specToApply.tlsVersions);
+    String[] tlsVersionsToEnable = specToApply.tlsVersions;
+    // null means "use default set".
+    if (tlsVersionsToEnable != null) {
+      sslSocket.setEnabledProtocols(tlsVersionsToEnable);
+    }
 
     String[] cipherSuitesToEnable = specToApply.cipherSuites;
     // null means "use default set".
@@ -169,8 +173,12 @@ private ConnectionSpec supportedSpec(SSLSocket sslSocket, boolean isFallback) {
       }
     }
 
-    String[] protocolsToSelectFrom = sslSocket.getEnabledProtocols();
-    String[] protocolsToEnable = Util.intersect(String.class, tlsVersions, protocolsToSelectFrom);
+    String[] protocolsToEnable = null;
+    if (tlsVersions != null) {
+      String[] protocolsToSelectFrom = sslSocket.getEnabledProtocols();
+      protocolsToEnable = Util.intersect(String.class, tlsVersions, protocolsToSelectFrom);
+    }
+
     return new Builder(this)
         .cipherSuites(cipherSuitesToEnable)
         .tlsVersions(protocolsToEnable)