Conversation
38980f6 to
941ef8e
Compare
grom72
commented
Feb 3, 2025
Owner
Author
grom72
left a comment
There was a problem hiding this comment.
Reviewed 1 of 3 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @grom72)
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Harmonize _D_DEBUG* and _D_LOG_CHECK* macros parameters name with documentation: level - log message priority and debug bits/mask flags - complete logging information including message priority, facility and additional flags like per-message log flag values (e.g. DLOG_STDERR) Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
Signed-off-by: Tomasz Gromadzki <tomasz.gromadzki@hpe.com>
2bd6120 to
110fb36
Compare
grom72
commented
Feb 3, 2025
Owner
Author
grom72
left a comment
There was a problem hiding this comment.
Reviewed 3 of 3 files at r5.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @grom72)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before requesting gatekeeper:
Features:(orTest-tag*) commit pragma was used or there is a reason documented that there are no appropriate tags for this PR.Gatekeeper:
This change is