fix: add mcp[ws] dependency for websocket support#74
Conversation
|
Thanks for highlighting this and proposing a fix I saw the issue when merging #73 but somehow I didn't have any issue neither in the test env or my local env I thought the websocket package must be included as a dependency somewhere. Have you observed a specific error related? Also I am wondering why is it an optional dependency on MCP is it that large of a package to not come with the rest? |
|
Hi, I install in As for why |
|
Ok its a bit of a mess because on mac intel there is no wheel for the latest torch audio. I will merge and release this change for unblocking everyone. Sorry for the delay. |
|
Thanks a lot for the fix @grll and @Edison-A-N. |
|
I appreciate the quick fix on this, thank you! |
|
@grll Hi, I apologize for the oversight in this PR 🙏 While working on PR #76 (fault tolerance feature), I discovered that I only updated Impact
FixI have the corrected +[package.optional-dependencies]
+ws = [
+ { name = "websockets" },
+]
- { name = "mcp" },
+ { name = "mcp", extra = ["ws"] },Would you like me to submit a patch PR to fix this, or would you prefer to handle it differently? Sorry again for not following the proper contribution workflow! |
Add WebSocket Dependency to MCP
Issue
core.pyuseswebsocket_clientfrom MCP SDK, but the requiredwebsocketsdependency is not installed by default.Changes
Updated
pyproject.toml:mcp>=1.10.1→mcp[ws]>=1.10.1This ensures the
websockets>=15.0.1package is automatically installed, enabling WebSocket transport support incore.py.Type
Critical Bug Fix - Resolves ImportError and restores WebSocket functionality.