Enable Optional inputs in CrewAI adapter#53
Closed
electrocucaracha wants to merge 1 commit intogrll:mainfrom
Closed
Enable Optional inputs in CrewAI adapter#53electrocucaracha wants to merge 1 commit intogrll:mainfrom
electrocucaracha wants to merge 1 commit intogrll:mainfrom
Conversation
The current implementation of the CrewAI adapter doesn't cover the scenario where the argument is optional. This change fixes that and provides an assertion to validate what is received by the MCP echo server.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current CrewAI adapter implementation requires passing all the values for arguments that don't have a default value, but fails when the MCP tool provides an optional argument. For example, the following code:
Results in the following error
When the tool doesn't provide an
idvalue, liketools[0].run(text="hello")This change modifies the way to populate
filtered_kwargsvariable utilizing theschema_propertiesvalues instead of thekwargs