docs: Add reverse proxy X-Forwarded-Port blurb#33
Conversation
📝 WalkthroughWalkthroughDocumentation update adds a clarifying note about configuring ChangesReverse proxy configuration clarification
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Suggested labels
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/integration/kobo.md`:
- Around line 39-40: The admonition started with :::info[X-Forwarded-Port] is
left unclosed; update the block to follow the same open/body/close pattern used
elsewhere by placing the explanatory text as the body beneath the opener and
adding a closing ::: on its own line (i.e., keep the existing opener
':::info[X-Forwarded-Port]', move the explanatory sentence into the body, then
add ':::' to end the admonition).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: d4cd48b9-b7f0-493e-a5ac-78f4f07b5b6d
📒 Files selected for processing (1)
docs/integration/kobo.md
| large_client_header_buffers 8 32k; | ||
| ``` | ||
|
|
||
| :::info[X-Forwarded-Port] It's common in reverse proxy setups to port forward public listening ports to a different internal port. If your public listening port is different from $server_port, you must set X-Forwarded-Port to the public listening port. ie. public exposed port is 443 while nginx is listening on 8443 |
There was a problem hiding this comment.
| :::info[X-Forwarded-Port] It's common in reverse proxy setups to port forward public listening ports to a different internal port. If your public listening port is different from $server_port, you must set X-Forwarded-Port to the public listening port. ie. public exposed port is 443 while nginx is listening on 8443 | |
| :::info[X-Forwarded-Port] | |
| If your public listening port is different from your internal $server_port, you should set X-Forwarded-Port to the public listening port. | |
| For example, if your public server is available on port 443, but nginx is listening on 8443 you will need to set X-Forwarded-Port to port 443. |
Thoughts on this rewording? I also added a newline. I don't know if that's needed but it's how the other alert boxes are.
Description
It's common for reverse proxy homelab setups to port forward a different public port to different internal port that the reverse proxy is listening on. Added a blurb to point out that X-Forwarded-Port may need a different setting.
Linked Issue
https://github.com/orgs/grimmory-tools/discussions/1476
Changes
Add info section to clarify
X-Forwarded-Portreverse proxy header valuesAI Disclosure
AI not used
Checklist
npm run buildand/ornpm run typecheck.Summary by CodeRabbit