Add logs on voltage limits by Tristan-WorkGH · Pull Request #46 · gridsuite/voltage-init-server

Tristan-WorkGH · 2024-03-22T08:42:55Z

Add logs
- logs tree in serialized JSON in resources like in others analysis servers
- central shared root reporter in analysis context
- also move existing log line where it's calculated to have all logs in one place
Add missing lombok config, which fix wrong coverage
Fix resource loading problems with classpath in tests

Dupplicate code

generated code not marked as it for coverage

ne0ds · 2024-03-26T12:18:25Z

pom.xml

-            <groupId>junit</groupId>
-            <artifactId>junit</artifactId>
-            <scope>test</scope>
-        </dependency>


Unrelated change

Moved to #51

ne0ds · 2024-03-26T12:18:58Z

.mvn/lombok-config-copy.marker

What is the purpose of this file?

The project was missing .mvn/lombok-config-copy.marker & lombok.config, with consequence of very bad coverage with Sonar for example.

ne0ds · 2024-03-26T12:19:12Z

lombok.config

What is the purpose of this file?

use common lombok config as base

pom.xml

-            <groupId>junit</groupId>
-            <artifactId>junit</artifactId>
-            <scope>test</scope>
-        </dependency>


src/main/java/org/gridsuite/voltageinit/server/service/VoltageInitRunContext.java

...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java

src/test/java/org/gridsuite/voltageinit/service/ReportServiceTest.java

src/test/java/org/gridsuite/voltageinit/utils/TestUtils.java

src/test/java/org/gridsuite/voltageinit/utils/assertions/ReflectiveRepresentation.java

...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java

src/test/java/org/gridsuite/voltageinit/server/VoltageInitParametersTest.java

replace `@TestFactory` by individual `@Test`

problem of SpringBoot contexts when mixing JUnit4 & JUnit5

clean PR

src/main/java/org/gridsuite/voltageinit/server/service/VoltageInitWorkerService.java

src/main/java/org/gridsuite/voltageinit/server/service/VoltageInitRunContext.java

...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java

antoinebhs · 2024-04-08T15:30:40Z

...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java


-        long nanoTime = System.nanoTime();
-        LOGGER.info("Parameters built in {}s", TimeUnit.NANOSECONDS.toSeconds(System.nanoTime() - startTime.getAndSet(nanoTime)));
+        LOGGER.info("Parameters built in {}s", TimeUnit.NANOSECONDS.toSeconds(System.nanoTime() - startTime));


Not necessary for this PR, to revert

...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java

src/test/java/org/gridsuite/voltageinit/server/VoltageInitParametersTest.java

Signed-off-by: Tristan Chuine <tristan.chuine_externe@rte-france.com>

...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java

This reverts commit 5e6bdda.

src/main/java/org/gridsuite/voltageinit/server/service/VoltageInitRunContext.java

...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java

sonarqubecloud · 2024-04-10T14:27:32Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
96.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

antoinebhs

Code OK
Test OK

Tristan-WorkGH added 13 commits March 19, 2024 15:05

Unnecessary @ComponentScan

c8c4009

Dupplicate code

fix final root reporter

2ddfc46

simplify streams

c6ede79

simplify chrono

bc03a8f

refactor voltage limits

70739ca

fix cast

508c5ac

fix constructor

71180a9

migrate tests to junit5

aff60c2

clean SpringBootTest

44f827a

prepare test

bd91ab1

Add basic logs control

71585a3

Move reporter logs near building logic

5ab800f

Added new logs

8fb02ec

Tristan-WorkGH self-assigned this Mar 22, 2024

Tristan-WorkGH added 3 commits March 22, 2024 10:14

Merge remote-tracking branch 'origin/main' into add_logs

96cc4bd

fix checkstyle

9b3dbc3

Add missing lombok config

cd42064

generated code not marked as it for coverage

Tristan-WorkGH force-pushed the add_logs branch from e9aa164 to e5c47e8 Compare March 22, 2024 11:45

clean PR

fc7e221

Tristan-WorkGH force-pushed the add_logs branch from e5c47e8 to fc7e221 Compare March 22, 2024 13:45

ne0ds self-requested a review March 26, 2024 09:14

ne0ds reviewed Mar 26, 2024

View reviewed changes

Merge remote-tracking branch 'origin/main' into add_logs

d06fe52

etiennehomer requested changes Mar 26, 2024

View reviewed changes

src/test/java/org/gridsuite/voltageinit/server/VoltageInitParametersTest.java Outdated Show resolved Hide resolved

Tristan-WorkGH added 3 commits March 27, 2024 16:52

review

438e199

replace `@TestFactory` by individual `@Test`

fix tests

68cf7b5

problem of SpringBoot contexts when mixing JUnit4 & JUnit5

review

e0ec908

clean PR

antoinebhs requested changes Apr 8, 2024

View reviewed changes

Tristan-WorkGH added 3 commits April 8, 2024 17:38

review

0a96d37

review

27f6583

revert 5805e75

3f94e7c

antoinebhs reviewed Apr 9, 2024

View reviewed changes

src/test/java/org/gridsuite/voltageinit/server/VoltageInitParametersTest.java Show resolved Hide resolved

Tristan-WorkGH added 3 commits April 9, 2024 16:17

review

8301e9d

Signed-off-by: Tristan Chuine <tristan.chuine_externe@rte-france.com>

review (bis)

1a7f24d

review

dbb6a39

Tristan-WorkGH force-pushed the add_logs branch from 2dcc28e to dbb6a39 Compare April 9, 2024 16:37

Tristan-WorkGH added 2 commits April 9, 2024 18:54

optimize memory usage

5e6bdda

fix message value format

50266a1

Tristan-WorkGH requested review from antoinebhs and etiennehomer April 10, 2024 10:18

etiennehomer reviewed Apr 10, 2024

View reviewed changes

...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java Outdated Show resolved Hide resolved

Tristan-WorkGH added 3 commits April 10, 2024 14:02

Revert "optimize memory usage"

4fe8d79

This reverts commit 5e6bdda.

checkstyle

f61e7a7

review

7d042e2

Tristan-WorkGH requested a review from etiennehomer April 10, 2024 12:10

Tristan-WorkGH added 2 commits April 10, 2024 14:10

Merge remote-tracking branch 'origin/main' into add_logs

b4f051a

rename constant

01020e9

etiennehomer requested changes Apr 10, 2024

View reviewed changes

Tristan-WorkGH added 2 commits April 10, 2024 14:37

review

94000b5

fix sanor

6291593

etiennehomer approved these changes Apr 10, 2024

View reviewed changes

antoinebhs reviewed Apr 10, 2024

View reviewed changes

...n/java/org/gridsuite/voltageinit/server/service/parameters/VoltageInitParametersService.java Outdated Show resolved Hide resolved

review

c21ef21

Tristan-WorkGH requested a review from antoinebhs April 10, 2024 14:25

antoinebhs approved these changes Apr 10, 2024

View reviewed changes

Tristan-WorkGH merged commit 17f00d4 into main Apr 10, 2024

Conversation

Tristan-WorkGH commented Mar 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ne0ds Mar 26, 2024

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Tristan-WorkGH Mar 27, 2024

Choose a reason for hiding this comment

Uh oh!

ne0ds Mar 26, 2024

Choose a reason for hiding this comment

Uh oh!

Tristan-WorkGH Mar 27, 2024

Choose a reason for hiding this comment

Uh oh!

ne0ds Mar 26, 2024

Choose a reason for hiding this comment

Uh oh!

Tristan-WorkGH Mar 27, 2024

Choose a reason for hiding this comment

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

antoinebhs Apr 8, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Apr 10, 2024

Quality Gate passed

Uh oh!

antoinebhs left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Tristan-WorkGH commented Mar 22, 2024 •

edited

Loading