Use computation to configure load balancing for consumeRun#143
Use computation to configure load balancing for consumeRun#143klesaulnier merged 5 commits intomainfrom
Conversation
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 3 minutes and 16 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📝 WalkthroughWalkthroughThe Changes
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/test/resources/application-default.yml (1)
13-14: Add one integration path that exercises both run consumers.Line 13-Line 14 intentionally disables
consumeRun2, which keeps tests stable, but it also means the new dual-consumer wiring is never exercised in tests. Consider adding one dedicated integration scenario withconsumeRun1;consumeRun2;consumeCancelto catch binding regressions early.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/test/resources/application-default.yml` around lines 13 - 14, Add a dedicated integration scenario in the test configuration so the dual-consumer wiring is exercised: create an additional test profile or entry in application-default.yml that sets the message binding "definition" to "consumeRun1;consumeRun2;consumeCancel" (instead of the current single-line disabling of consumeRun2) and ensure your integration test(s) pick up that profile or config; update any test bootstrap or `@ActiveProfiles` usage to run this scenario so binding regressions for consumeRun2 are caught.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/test/resources/application-default.yml`:
- Around line 13-14: Add a dedicated integration scenario in the test
configuration so the dual-consumer wiring is exercised: create an additional
test profile or entry in application-default.yml that sets the message binding
"definition" to "consumeRun1;consumeRun2;consumeCancel" (instead of the current
single-line disabling of consumeRun2) and ensure your integration test(s) pick
up that profile or config; update any test bootstrap or `@ActiveProfiles` usage to
run this scenario so binding regressions for consumeRun2 are caught.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 83863a7f-7677-4480-b7aa-12e188330377
📒 Files selected for processing (3)
src/main/java/org/gridsuite/voltageinit/server/service/VoltageInitWorkerService.javasrc/main/resources/config/application.yamlsrc/test/resources/application-default.yml
Signed-off-by: LE SAULNIER Kevin <kevin.lesaulnier.pro@gmail.com>
|



PR Summary