persist computation result filters by ghazwarhili · Pull Request #97 · gridsuite/study-config-server

ghazwarhili · 2026-01-28T10:29:48Z

PR Summary

persist computation result filters

...ain/java/org/gridsuite/studyconfig/server/controller/ComputationResultFiltersController.java

...main/java/org/gridsuite/studyconfig/server/entities/ComputationResultColumnFilterEntity.java

src/main/java/org/gridsuite/studyconfig/server/dto/ComputationResultColumnFilterInfos.java

...main/java/org/gridsuite/studyconfig/server/entities/ComputationResultColumnFilterEntity.java

…ters

src/main/java/org/gridsuite/studyconfig/server/dto/ComputationResultColumnFilterInfos.java

src/main/java/org/gridsuite/studyconfig/server/dto/ColumnInfos.java

src/main/java/org/gridsuite/studyconfig/server/dto/ComputationResultFiltersInfos.java

src/main/java/org/gridsuite/studyconfig/server/dto/ComputationTypeFiltersInfos.java

src/main/java/org/gridsuite/studyconfig/server/dto/ComputationSubTypeFilterInfos.java

src/main/java/org/gridsuite/studyconfig/server/entities/ColumnEntity.java

src/main/java/org/gridsuite/studyconfig/server/service/SpreadsheetConfigService.java

src/main/java/org/gridsuite/studyconfig/server/service/ComputationResultFiltersService.java

src/main/java/org/gridsuite/studyconfig/server/entities/ComputationSubTypeFiltersEntity.java

src/main/java/org/gridsuite/studyconfig/server/entities/computationresult/FilterTypeEntity.java

etiennehomer

Some seq scan. Check that all the required indexes are set
2026-02-04 08:27:57.675 UTC [16300] LOG: duration: 0.010 ms plan:
postgres-1 | Query Text: select crf1_0.computation_result_filters_id,crf1_0.uuid,crf1_0.computation_type from computation_type_filters crf1_0 where crf1_0.computation_result_filters_id=$1
postgres-1 | Seq Scan on computation_type_filters crf1_0 (cost=10000000000.00..10000000011.75 rows=1 width=548)
postgres-1 | Filter: (computation_result_filters_id = '1321a8f5-37b2-410d-adff-6bea8002feda'::uuid)

src/main/java/org/gridsuite/studyconfig/server/service/ComputationResultFiltersService.java

…ters

src/main/resources/db/changelog/changesets/changelog_20260128T102437Z.xml

src/test/java/org/gridsuite/studyconfig/server/ComputationResultFiltersTest.java

…tps://github.com/gridsuite/study-config-server into persist-computation-result-global-column-filters

Signed-off-by: Etienne Homer <etiennehomer@gmail.com>

sonarqubecloud · 2026-02-06T16:59:40Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
88.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

etiennehomer · 2026-02-06T17:00:41Z

Some seq scan. Check that all the required indexes are set 2026-02-04 08:27:57.675 UTC [16300] LOG: duration: 0.010 ms plan: postgres-1 | Query Text: select crf1_0.computation_result_filters_id,crf1_0.uuid,crf1_0.computation_type from computation_type_filters crf1_0 where crf1_0.computation_result_filters_id=$1 postgres-1 | Seq Scan on computation_type_filters crf1_0 (cost=10000000000.00..10000000011.75 rows=1 width=548) postgres-1 | Filter: (computation_result_filters_id = '1321a8f5-37b2-410d-adff-6bea8002feda'::uuid)

Fixed with indexes

persist computation result filters

dc88850

etiennehomer requested changes Jan 28, 2026

View reviewed changes

ghazwarhili added 12 commits January 29, 2026 10:13

refacto column entity

ce26203

refacto to column filter entity

e3b2318

Merge branch 'main' into persist-computation-result-global-column-fil…

2530469

…ters

add TU

1fb33f7

some fix

a06a86f

some fix

f8b91f5

update TU

b12a1e0

unused functions

c0da42d

fix TU

cd19324

add sql file data migration

460d3fa

fix sql script

a1f9136

formatted file

5699270

etiennehomer requested changes Feb 3, 2026

View reviewed changes

src/main/java/org/gridsuite/studyconfig/server/service/SpreadsheetConfigService.java Outdated Show resolved Hide resolved

etiennehomer requested changes Feb 3, 2026

View reviewed changes

code review remarks

7cf28fc

ghazwarhili requested a review from etiennehomer February 4, 2026 08:17

ghazwarhili added 3 commits February 4, 2026 10:16

revert

4531f52

code review remarks

4340731

rename to computationResultFiltersId

bc2aa72

etiennehomer requested changes Feb 5, 2026

View reviewed changes

src/main/java/org/gridsuite/studyconfig/server/service/ComputationResultFiltersService.java Outdated Show resolved Hide resolved

ghazwarhili added 2 commits February 5, 2026 11:37

rename to computationResultsFiltersId

64a8651

Merge branch 'main' into persist-computation-result-global-column-fil…

2f4d5df

…ters

etiennehomer requested changes Feb 5, 2026

View reviewed changes

src/main/resources/db/changelog/changesets/changelog_20260128T102437Z.xml Outdated Show resolved Hide resolved

src/test/java/org/gridsuite/studyconfig/server/ComputationResultFiltersTest.java Outdated Show resolved Hide resolved

ghazwarhili added 2 commits February 5, 2026 14:46

code review remarks

805a0af

Merge branch 'persist-computation-result-global-column-filters' of ht…

cb1606e

…tps://github.com/gridsuite/study-config-server into persist-computation-result-global-column-filters

ghazwarhili requested a review from etiennehomer February 5, 2026 13:51

ghazwarhili and others added 4 commits February 6, 2026 13:33

add idx_computation_result_filters_id

300546b

add delete column case

8def8ad

code review remarks

fa3eced

rename parameter

972b4a5

Signed-off-by: Etienne Homer <etiennehomer@gmail.com>

etiennehomer approved these changes Feb 6, 2026

View reviewed changes

ghazwarhili merged commit cc82230 into main Feb 6, 2026
3 checks passed

ghazwarhili deleted the persist-computation-result-global-column-filters branch February 6, 2026 17:01

Comments

Conversation

ghazwarhili commented Jan 28, 2026

PR Summary

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

etiennehomer left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Feb 6, 2026

Quality Gate passed

Uh oh!

etiennehomer commented Feb 6, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

etiennehomer left a comment •

edited

Loading