Add high tap position fields to TwoWindingsTransformerField#162
Merged
Add high tap position fields to TwoWindingsTransformerField#162
Conversation
…sTransformerField Add high tap position fields for both ratio and phase tap changers in TwoWindingsTransformerField enum. These read-only fields are handled in isEquipmentEditable and getReferenceValue methods, following the same pattern as their LOW_TAP_POSITION counterparts. Signed-off-by: Florent <florent@users.noreply.github.com> Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
…ble fields in TwoWindingsTransformerField Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
Integrate validation for RATIO_HIGH_TAP_POSITION and PHASE_HIGH_TAP_POSITION to ensure their values remain consistent and unmodified in assignment and formula modifications. Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
… test assertions Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
…transformers Enhance test coverage for RATIO_HIGH_TAP_POSITION and PHASE_HIGH_TAP_POSITION with new filters, formula modifications, and non-editable field validations in assignment tests. Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
…odificationByAssignmentTest Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
…to add-high-tap-position-fields
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RATIO_HIGH_TAP_POSITIONandPHASE_HIGH_TAP_POSITIONenum values toTwoWindingsTransformerFieldisEquipmentEditable(not editable)getReferenceValueusinggetHighTapPosition()on the corresponding tap changer