Skip to content

Replace usage of BusbarSectionFinderTraverser with the one from Powsybl-core#160

Merged
basseche merged 5 commits into
mainfrom
suppress_BusbarSectionFinderTraverser
May 21, 2026
Merged

Replace usage of BusbarSectionFinderTraverser with the one from Powsybl-core#160
basseche merged 5 commits into
mainfrom
suppress_BusbarSectionFinderTraverser

Conversation

@basseche
Copy link
Copy Markdown
Contributor

PR Summary

Replace usage of BusbarSectionFinderTraverser with the one from Powsybl-core

@basseche basseche self-assigned this Feb 10, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 18, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 577d17a0-c12e-43ce-8b0b-47e041b8dd1e

📥 Commits

Reviewing files that changed from the base of the PR and between 90ee733 and 495cf16.

📒 Files selected for processing (5)
  • src/main/java/org/gridsuite/modification/modifications/BusbarSectionFinderTraverser.java
  • src/main/java/org/gridsuite/modification/utils/ModificationUtils.java
  • src/test/java/org/gridsuite/modification/modifications/GeneratorModificationTest.java
  • src/test/java/org/gridsuite/modification/modifications/TwoWindingsTransformerModificationTest.java
  • src/test/java/org/gridsuite/modification/utils/BusbarSectionFinderTraverserTest.java
💤 Files with no reviewable changes (2)
  • src/test/java/org/gridsuite/modification/utils/BusbarSectionFinderTraverserTest.java
  • src/main/java/org/gridsuite/modification/modifications/BusbarSectionFinderTraverser.java

📝 Walkthrough

Walkthrough

The PR removes the local BusbarSectionFinderTraverser implementation and associated tests, migrating the codebase to use the external com.powsybl.iidm.network.util.BusbarSectionFinderTraverser version. Import statements are updated across ModificationUtils and test files to reference the new library location.

Changes

Library Migration

Layer / File(s) Summary
Import updates to external library version
src/main/java/org/gridsuite/modification/utils/ModificationUtils.java, src/test/java/org/gridsuite/modification/modifications/GeneratorModificationTest.java, src/test/java/org/gridsuite/modification/modifications/TwoWindingsTransformerModificationTest.java
Import statements updated from org.gridsuite.modification.modifications.BusbarSectionFinderTraverser to com.powsybl.iidm.network.util.BusbarSectionFinderTraverser across utilities and test files.

Suggested Reviewers

  • antoinebhs
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: replacing the local BusbarSectionFinderTraverser implementation with the one from Powsybl-core, which is reflected in the removal of the local class and updated imports.
Description check ✅ Passed The description directly relates to the changeset, stating the intent to replace BusbarSectionFinderTraverser with the Powsybl-core version, which matches the actual changes made.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

@basseche basseche merged commit 286f4c9 into main May 21, 2026
5 checks passed
@basseche basseche deleted the suppress_BusbarSectionFinderTraverser branch May 21, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants