feat: handle p and q measurement modification in battery#817
Conversation
Signed-off-by: Kamil MARUT <kamil.marut@rte-france.com>
📝 WalkthroughWalkthroughBattery modifications now support measurement-related fields (active and reactive power values with validity flags). The entity was extended to map these fields during modification info construction, the upstream dependency version was updated, and test coverage added measurement constants, builder configuration, and validation assertions. ChangesBattery Measurement Fields
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pom.xml`:
- Line 56: Update the Maven property network-modification.version to remove the
SNAPSHOT and point to a released artifact: change the value from 0.82.0-SNAPSHOT
to a released version (e.g., 0.78.0) so builds are reproducible; ensure any
references to org.gridsuite:gridsuite-network-modification in the pom(s) use
that released version and run a quick mvn -DskipTests verify to confirm
dependency resolution succeeds before merging.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 98d86604-cd75-4613-be57-8e6ae3adb048
📒 Files selected for processing (3)
pom.xmlsrc/main/java/org/gridsuite/modification/server/entities/equipment/modification/BatteryModificationEntity.javasrc/test/java/org/gridsuite/modification/server/modifications/BatteryModificationTest.java
| <sonar.projectKey>org.gridsuite:network-modification-server</sonar.projectKey> | ||
| <!-- TODO network-modification.version remove when included in gridsuite-dependencies --> | ||
| <network-modification.version>0.81.0</network-modification.version> | ||
| <network-modification.version>0.82.0-SNAPSHOT</network-modification.version> <!-- TODO UPDATE TO CORRECT VERSION AFTER NETWORK MODIFICATION IS UPDATED --> |
There was a problem hiding this comment.
🧩 Analysis chain
🌐 Web query:
What is the latest released (non-SNAPSHOT) version of Maven artifact org.gridsuite:gridsuite-network-modification, and is 0.82.0 available as a stable release?
💡 Result:
As of May 18, 2026, the latest released (non-SNAPSHOT) version of the Maven artifact org.gridsuite:gridsuite-network-modification is 0.78.0 [1]. Regarding version 0.82.0, there is no evidence that this version is available as a stable release. The official repository indicates that the latest release is v0.72.0 [2][3], and while some external indexing services reference version 0.78.0 [1], version 0.82.0 has not been identified as a released artifact.
Citations:
- 1: https://central.sonatype.com/artifact/org.gridsuite/gridsuite-network-modification/0.78.0
- 2: https://github.com/gridsuite/network-modification
- 3: https://github.com/gridsuite/network-modification/releases/tag/v0.72.0
Remove SNAPSHOT dependency from main branch and use a released version.
Using 0.82.0-SNAPSHOT makes builds non-reproducible and can break unexpectedly when upstream republishes artifacts. The latest released version of org.gridsuite:gridsuite-network-modification is 0.78.0. Either upgrade to 0.78.0, wait for 0.82.0 to be released, or use a temporary branch-only strategy before merging.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@pom.xml` at line 56, Update the Maven property network-modification.version
to remove the SNAPSHOT and point to a released artifact: change the value from
0.82.0-SNAPSHOT to a released version (e.g., 0.78.0) so builds are reproducible;
ensure any references to org.gridsuite:gridsuite-network-modification in the
pom(s) use that released version and run a quick mvn -DskipTests verify to
confirm dependency resolution succeeds before merging.
PR Summary