Skip to content

Comments

add regulationType to GeneratorTabInfos#324

Merged
ghazwarhili merged 3 commits intomainfrom
add-regulationTypeText-to-GeneratorTabInfos
Feb 11, 2026
Merged

add regulationType to GeneratorTabInfos#324
ghazwarhili merged 3 commits intomainfrom
add-regulationTypeText-to-GeneratorTabInfos

Conversation

@ghazwarhili
Copy link
Contributor

PR Summary

add regulationTypeText to GeneratorTabInfos

Copy link
Contributor

@Meklo Meklo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the column went from being called RegulationTypeText to regulationTypeText I think a small migration in study-config-server is necesary as well as an update to default-spreadsheet-config-collection.json to keep forwarding to the data, otherwise it won't show up in preexisting and new configs

@ghazwarhili
Copy link
Contributor Author

Since the column went from being called RegulationTypeText to regulationTypeText I think a small migration in study-config-server is necesary as well as an update to default-spreadsheet-config-collection.json to keep forwarding to the data, otherwise it won't show up in preexisting and new configs

done here gridsuite/study-config-server#99

@ghazwarhili ghazwarhili requested a review from Meklo February 10, 2026 15:28

public enum VoltageRegulationType {
LOCAL,
DISTANT
Copy link
Contributor

@Meklo Meklo Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Post validation remark sorry, after thinking about it DISTANT is the french term but raw data from the back should only but in english so maybe we should swap it for REMOTE as it is in the english version of the forms

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

renamed to
public enum RegulationType {
LOCAL,
REMOTE
}

@sonarqubecloud
Copy link

@ghazwarhili ghazwarhili requested a review from Meklo February 11, 2026 09:04
@ghazwarhili ghazwarhili changed the title add regulationTypeText to GeneratorTabInfos add regulationType to GeneratorTabInfos Feb 11, 2026
@ghazwarhili ghazwarhili merged commit a49420f into main Feb 11, 2026
3 checks passed
@ghazwarhili ghazwarhili deleted the add-regulationTypeText-to-GeneratorTabInfos branch February 11, 2026 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants