Skip to content

add @JsonProperty to qAtNominalV and bPerSection #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghazwarhili merged 4 commits into from
Feb 3, 2026
Merged

add @JsonProperty to qAtNominalV and bPerSection #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
791e59e
add @JsonProperty to qAtNominalV and bPerSection
ghazwarhili Feb 3, 2026
50e0cf2
fix bPerSection and qAtNominalV
ghazwarhili Feb 3, 2026
8cb23ba
code review remarks
ghazwarhili Feb 3, 2026
a6ca1ed
unused import
ghazwarhili Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .../org/gridsuite/network/map/dto/definition/shuntcompensator/ShuntCompensatorFormInfos.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@
package org.gridsuite.network.map.dto.definition.shuntcompensator;

import com.fasterxml.jackson.annotation.JsonInclude;
import com.fasterxml.jackson.annotation.JsonProperty;
import lombok.AccessLevel;
import lombok.Getter;
import lombok.experimental.SuperBuilder;
import org.gridsuite.network.map.dto.ElementInfosWithProperties;
Expand Down Expand Up @@ -34,9 +36,13 @@ public class ShuntCompensatorFormInfos extends ElementInfosWithProperties {
private Integer sectionCount;

@JsonInclude(JsonInclude.Include.NON_NULL)
@JsonProperty("bPerSection")
@Getter(AccessLevel.NONE)
private Double bPerSection;

@JsonInclude(JsonInclude.Include.NON_NULL)
@JsonProperty("qAtNominalV")
@Getter(AccessLevel.NONE)
private Double qAtNominalV;

private Integer maximumSectionCount;
Expand Down
12 changes: 6 additions & 6 deletions src/test/resources/partial-shunt-compensators-map-data-in-variant.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@
"targetDeadband": 10.0,
"sectionCount":4,
"maximumSectionCount":8,
"bperSection":5.0,
"bPerSection":5.0,
"connectionName": "feederName",
"connectionDirection": "TOP",
"connectionPosition": 0,
"qatNominalV": 253125.0
"qAtNominalV": 253125.0
},
{
"id": "SHUNT2",
Expand All @@ -24,11 +24,11 @@
"targetDeadband": 10.0,
"sectionCount":2,
"maximumSectionCount":3,
"bperSection":1.0,
"bPerSection":1.0,
"connectionName": "feederName",
"connectionDirection": "TOP",
"connectionPosition": 0,
"qatNominalV": 576.0
"qAtNominalV": 576.0
},
{
"id": "SHUNT3",
Expand All @@ -40,10 +40,10 @@
"targetDeadband": 10.0,
"sectionCount":2,
"maximumSectionCount":3,
"bperSection":1.0,
"bPerSection":1.0,
"connectionName": "feederName",
"connectionDirection": "TOP",
"connectionPosition": 0,
"qatNominalV": 576.0
"qAtNominalV": 576.0
}
]
4 changes: 2 additions & 2 deletions src/test/resources/partial-shunt-compensators-map-data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,10 @@
"targetDeadband": 10.0,
"sectionCount": 4,
"maximumSectionCount": 8,
"bperSection": 5.0,
"bPerSection": 5.0,
"connectionName": "feederName",
"connectionDirection": "TOP",
"connectionPosition": 0,
"qatNominalV": 253125.0
"qAtNominalV": 253125.0
}
]
5 changes: 2 additions & 3 deletions src/test/resources/shunt-compensator-map-data-in-variant.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,12 @@
"targetDeadband": 10.0,
"sectionCount":2,
"maximumSectionCount":3,
"bperSection":1.0,
"connectablePosition": {
"connectionDirection": null
},
"busOrBusbarSectionId": "NGEN4",
"isLinear":true,
"bperSection":1.0,
"qatNominalV": 576.0
"bPerSection" : 1.0,
"qAtNominalV" : 576.0
}

5 changes: 2 additions & 3 deletions src/test/resources/shunt-compensator-map-data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,12 @@
"targetDeadband": 10.0,
"sectionCount":2,
"maximumSectionCount":3,
"bperSection":1.0,
"bPerSection" : 1.0,
"connectablePosition": {
"connectionDirection": null
},
"busOrBusbarSectionId": "NGEN4",
"isLinear":true,
"bperSection":1.0,
"qatNominalV": 576.0
"qAtNominalV" : 576.0
}