Enrich process config creation by FranckLecuyer · Pull Request #41 · gridsuite/monitor-core

FranckLecuyer · 2026-02-13T16:46:31Z

PR Summary

Add owner, creation date, last modification date and last user that did a modification

…n user to the process configs Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>

sonarqubecloud · 2026-02-16T12:51:16Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

antoinebhs

This PR asks the question where we want to save this data.
In the Gridsuite ecosystem, we do not save this data in all elements available in Gridexplore, it's handled by the directory server.
We need to discuss with the PO if we want in monitor to have our "ProcessConfig" explorer that do not use Gridexplore or if we want to use Gridexplore and instead of implementing it like that, we want a new GRidexplore object.
I will finish the review depending on what we choose.

antoinebhs · 2026-02-19T11:20:23Z

monitor-commons/src/main/java/org/gridsuite/monitor/commons/Constants.java

+/**
+ * @author Franck Lecuyer <franck.lecuyer at rte-france.com>
+ */
+public final class Constants {


I think the logic for now is to put in monitor-commons class that are commons to server and worker.
I see that these constants are only used in the server. So I would put this file in server/Constants.java

antoinebhs · 2026-02-19T15:58:47Z

monitor-commons/src/main/java/org/gridsuite/monitor/commons/AbstractProcessConfig.java

+ */
+@Getter
+public abstract class AbstractProcessConfig implements ProcessConfig {
+    @JsonProperty(required = true)


I don't really understand the logic here: why do we make it required but also add a null check:

this.modificationUuids = modificationUuids != null ? List.copyOf(modificationUuids) : null;

Why do we need an abstraction and can't continue using the record?

antoinebhs · 2026-02-19T16:15:13Z

monitor-commons/src/main/java/org/gridsuite/monitor/commons/ProcessConfig.java

-    List<UUID> modificationUuids();
+    List<UUID> getModificationUuids();
+
+    @JsonProperty(access = JsonProperty.Access.READ_ONLY)


This is readonly to avoid API requests with this data, right?

antoinebhs · 2026-02-19T16:15:55Z

monitor-commons/src/main/java/org/gridsuite/monitor/commons/SecurityAnalysisConfig.java

-) implements ProcessConfig {
+@Getter
+@EqualsAndHashCode(callSuper = true)
+public class SecurityAnalysisConfig extends AbstractProcessConfig {


same comment for the record vs class and null/required

antoinebhs · 2026-02-19T16:23:38Z

...-server/src/main/java/org/gridsuite/monitor/server/entities/AbstractProcessConfigEntity.java

    @OrderColumn(name = "pos_modifications")
    private List<UUID> modificationUuids;

+    @Column(name = "owner", length = 80, nullable = false)


we usually don't constrain in the bd but it see that it's consistent with directory server