Skip to content

Show error message in DnDTable#3955

Open
thangqp wants to merge 5 commits into
mainfrom
dnd_table_show_error_message
Open

Show error message in DnDTable#3955
thangqp wants to merge 5 commits into
mainfrom
dnd_table_show_error_message

Conversation

@thangqp
Copy link
Copy Markdown
Contributor

@thangqp thangqp commented May 21, 2026

PR Summary

Adapt to change in : gridsuite/commons-ui#1143

Signed-off-by: Thang PHAM <phamthang37@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 21, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ae3fca48-53ae-46a1-bd43-e8f637c18771

📥 Commits

Reviewing files that changed from the base of the PR and between 788b335 and d004e83.

📒 Files selected for processing (2)
  • src/components/dialogs/limits/temporary-limits-table.tsx
  • src/components/spreadsheet-view/spreadsheet/spreadsheet-toolbar/global-model-editor/columnName-editor.tsx
💤 Files with no reviewable changes (1)
  • src/components/spreadsheet-view/spreadsheet/spreadsheet-toolbar/global-model-editor/columnName-editor.tsx

📝 Walkthrough

Walkthrough

This pull request refactors error message display handling in table input components. Two components are updated to move from showErrorMsg prop configuration to a hideErrorMessage pattern, while also adding explicit input property configuration through inputProps.

Changes

Error Display and Input Configuration Updates

Layer / File(s) Summary
Refactor error message and input prop handling in table inputs
src/components/dialogs/limits/temporary-limits-table.tsx, src/components/spreadsheet-view/spreadsheet/spreadsheet-toolbar/global-model-editor/columnName-editor.tsx
EditableTableCell forwards hideErrorMessage from column config to numeric and text inputs with updated styling, and ColumnNameEditor configures autoFocus and onBlur handlers through inputProps instead of using showErrorMsg.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Show error message in DnDTable' directly relates to the main objective of adapting to upstream changes in commons-ui that involve error message display functionality.
Description check ✅ Passed The description appropriately references the upstream PR (#1143 in commons-ui) that prompted these changes, providing context for understanding the purpose of the adaptations.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant