Skip to content

Use importParameters instead of importParametersRaw#3954

Open
etiennehomer wants to merge 1 commit into
mainfrom
delete_importParameterRaw
Open

Use importParameters instead of importParametersRaw#3954
etiennehomer wants to merge 1 commit into
mainfrom
delete_importParameterRaw

Conversation

@etiennehomer
Copy link
Copy Markdown
Contributor

@etiennehomer etiennehomer commented May 20, 2026

PR Summary

Using a Map<String, Object> for importParameters in RootNetworkInfos allows us to remove the importParametersRaw field. importParameters field can be used for the communications with the front and powsybl-network-conversion-server.

Linked PR:
gridsuite/study-server#990

Signed-off-by: Etienne Homer <etiennehomer@gmail.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 20, 2026

Review Change Stack

📝 Walkthrough

Walkthrough

This PR renames the importParametersRaw field to importParameters in the RootNetworkInfos interface. The type definition in network-modification-menu.type.ts is updated, and all usages in the root network creation and editing flows (root-network-panel-header.tsx and root-network-node-editor.tsx) are updated to match.

Changes

Field rename: importParametersRaw → importParameters

Layer / File(s) Summary
Field rename across type definition and usages
src/components/graph/menus/network-modifications/network-modification-menu.type.ts, src/components/graph/menus/root-network/root-network-panel-header.tsx, src/components/graph/menus/root-network/root-network-node-editor.tsx
RootNetworkInfos interface field importParametersRaw is renamed to importParameters. Both the createRootNetwork and updateRootNetwork payloads are updated to use the new field name with unchanged conditional assignment logic.

Suggested reviewers

  • Meklo
  • sBouzols
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: renaming the importParametersRaw field to importParameters across the codebase.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The PR description accurately describes the changeset: replacing importParametersRaw with importParameters in RootNetworkInfos and related files.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant