Fix spreadsheet showing empty rows after unrealizing an aliased node#3950
Open
flomillot wants to merge 2 commits into
Open
Fix spreadsheet showing empty rows after unrealizing an aliased node#3950flomillot wants to merge 2 commits into
flomillot wants to merge 2 commits into
Conversation
Spreadsheet rowData was pushed imperatively via setGridOption inside a useEffect gated by an isGridReady flag that was never reset when the grid unmounted. After unrealizing a node and navigating back to an aliased node, EquipmentTable remounted with a fresh AG Grid instance but isGridReady stayed true, so onGridReady did not trigger a re-render and the rowData effect ran once before the grid API was ready, ending as a no-op. With aliased nodes no fetch occurs, so rowData was never pushed again and the grid showed "No data". Pass rowData as a prop to CustomAGGrid so AG Grid keeps it in sync via its own render cycle, removing the race entirely. Also reset isGridReady when disabled flips to true so sort and filter effects re-apply on remount. Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR refactors row data synchronization in the spreadsheet grid. It removes an imperative effect that manually synced data via Ag-Grid's API, resets grid readiness on disabled state changes, and moves row data to declarative prop-based passing. ChangesRow Data Synchronization
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
basseche
approved these changes
May 20, 2026
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SpreadsheetContentpushedrowDatato AG Grid imperatively in auseEffectgated by anisGridReadyflag that was never reset when the grid unmounted. After unrealizing a node and navigating back to a node with an alias,EquipmentTableremounted with a fresh AG Grid instance butisGridReadystayedtrue, soonGridReadydid not trigger a re-render and therowDataeffect ran once before the grid API was ready — ending as a no-op. With aliased nodes the data is cached (no fetch), sorowDatawas never pushed again and the grid displayed "No data" until F5.rowDataas a prop toCustomAGGridinequipment-table.tsxso AG Grid keeps the rows in sync via its own render cycle, removing the race entirely.isGridReadytofalsewhendisabledflips totrue, so the sort and filter effects (which still depend on the flag) re-apply on remount in the same scenario.