Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
ActivePowerControlInfos,
ConnectablePositionFormInfos,
FieldConstants,
MeasurementInfo,
MinMaxReactiveLimitsFormInfos,
Property,
ReactiveCapabilityCurvePoints,
Expand Down Expand Up @@ -43,7 +44,12 @@ export type BatteryDialogSchemaBaseForm = {
[FieldConstants.TRANSIENT_REACTANCE]?: number | null;
};

export type BatteryModificationDialogSchemaForm = Partial<BatteryDialogSchemaBaseForm>;
export type BatteryModificationDialogSchemaForm = {
[FieldConstants.STATE_ESTIMATION]?: {
[FieldConstants.MEASUREMENT_P]?: MeasurementInfo;
[FieldConstants.MEASUREMENT_Q]?: MeasurementInfo;
};
} & Partial<BatteryDialogSchemaBaseForm>;

export interface BatteryFormInfos {
id: string;
Expand All @@ -63,5 +69,7 @@ export interface BatteryFormInfos {
connectionName?: string | null;
connectionPosition: string | null;
terminalConnected?: boolean | null;
measurementP: MeasurementInfo | undefined;
measurementQ: MeasurementInfo | undefined;
properties: Record<string, string> | undefined;
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ import {
ConnectivityNetworkProps,
FieldConstants,
FloatInput,
PowerMeasurementsForm,
PropertiesForm,
ReactiveLimitsForm,
ReactivePowerAdornment,
Expand Down Expand Up @@ -131,6 +132,11 @@ export function BatteryDialogTabsContent({
<Box hidden={tabIndex !== BatteryDialogTab.SPECIFIC_TAB}>
<GridSection title="ShortCircuit" />
<ShortCircuitForm previousValues={batteryToModify?.batteryShortCircuit} />
<GridSection title="MeasurementsSection" />
<PowerMeasurementsForm
activePowerMeasurement={batteryToModify?.measurementP}
reactivePowerMeasurement={batteryToModify?.measurementQ}
/>
</Box>

<Box hidden={tabIndex !== BatteryDialogTab.ADDITIONAL_INFORMATION_TAB}>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,9 @@ import {
getReactiveLimitsValidationSchema,
getReactiveLimitsFormData,
REMOVE,
getInjectionActiveReactivePowerEmptyFormData,
getInjectionActiveReactivePowerValidationSchemaProperties,
getInjectionActiveReactivePowerEditData,
} from '@gridsuite/commons-ui';
import { yupResolver } from '@hookform/resolvers/yup';
import yup from 'components/utils/yup-config';
Expand Down Expand Up @@ -67,6 +70,7 @@ const emptyFormData = {
...getActivePowerControlEmptyFormData(true),
...emptyProperties,
...getShortCircuitEmptyFormData(),
...getInjectionActiveReactivePowerEmptyFormData(FieldConstants.STATE_ESTIMATION),
};

const formSchema = yup
Expand All @@ -87,6 +91,7 @@ const formSchema = yup
}),
[FieldConstants.CONNECTIVITY]: getConnectivityWithPositionSchema(true),
[FieldConstants.REACTIVE_LIMITS]: getReactiveLimitsValidationSchema(true),
[FieldConstants.STATE_ESTIMATION]: getInjectionActiveReactivePowerValidationSchemaProperties(),
...getSetPointsSchema(true),
...getActivePowerControlSchema(true),
...getShortCircuitFormSchema(true),
Expand Down Expand Up @@ -166,6 +171,7 @@ export default function BatteryModificationDialog({
directTransX: editData?.directTransX?.value ?? null,
stepUpTransformerX: editData?.stepUpTransformerX?.value ?? null,
}),
...getInjectionActiveReactivePowerEditData(FieldConstants.STATE_ESTIMATION, editData),
});
},
[reset]
Expand Down Expand Up @@ -272,6 +278,7 @@ export default function BatteryModificationDialog({
const reactiveLimits = battery[FieldConstants.REACTIVE_LIMITS];
const isReactiveCapabilityCurveOn =
reactiveLimits?.[FieldConstants.REACTIVE_CAPABILITY_CURVE_CHOICE] === 'CURVE';
const stateEstimationData = battery[FieldConstants.STATE_ESTIMATION];
const batteryModificationInfos = {
type: MODIFICATION_TYPES.BATTERY_MODIFICATION.type,
uuid: editData?.uuid ?? null,
Expand Down Expand Up @@ -311,6 +318,18 @@ export default function BatteryModificationDialog({
reactiveCapabilityCurvePoints: isReactiveCapabilityCurveOn
? (reactiveLimits[FieldConstants.REACTIVE_CAPABILITY_CURVE_TABLE] ?? null)
: null,
pMeasurementValue: toModificationOperation(
stateEstimationData?.[FieldConstants.MEASUREMENT_P]?.[FieldConstants.VALUE]
),
pMeasurementValidity: toModificationOperation(
stateEstimationData?.[FieldConstants.MEASUREMENT_P]?.[FieldConstants.VALIDITY]
),
qMeasurementValue: toModificationOperation(
stateEstimationData?.[FieldConstants.MEASUREMENT_Q]?.[FieldConstants.VALUE]
),
qMeasurementValidity: toModificationOperation(
stateEstimationData?.[FieldConstants.MEASUREMENT_Q]?.[FieldConstants.VALIDITY]
),
properties: toModificationProperties(battery) ?? null,
directTransX: toModificationOperation(battery[FieldConstants.TRANSIENT_REACTANCE]),
stepUpTransformerX: toModificationOperation(battery[FieldConstants.TRANSFORMER_REACTANCE]),
Expand Down
4 changes: 4 additions & 0 deletions src/services/network-modification-types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,10 @@ export interface BatteryModificationInfos {
connectionName: AttributeModification<string> | null;
connectionPosition: AttributeModification<number> | null;
terminalConnected: AttributeModification<boolean> | null;
pMeasurementValue: AttributeModification<number> | null;
pMeasurementValidity: AttributeModification<boolean> | null;
qMeasurementValue: AttributeModification<number> | null;
qMeasurementValidity: AttributeModification<boolean> | null;
properties: Property[] | null;
directTransX: AttributeModification<number> | null;
stepUpTransformerX: AttributeModification<number> | null;
Expand Down
Loading