Skip to content

init yup config before creating form schemas#3942

Open
khouadrired wants to merge 8 commits into
mainfrom
refactor-required-field-message
Open

init yup config before creating form schemas#3942
khouadrired wants to merge 8 commits into
mainfrom
refactor-required-field-message

Conversation

@khouadrired
Copy link
Copy Markdown
Contributor

remove duplicate translations to use the ones in commons-ui

@khouadrired khouadrired requested a review from thangqp May 11, 2026 19:00
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f15c5151-5942-4fef-bacb-91eeeec8ceff

📥 Commits

Reviewing files that changed from the base of the PR and between 5b308ec and bb9eacf.

📒 Files selected for processing (1)
  • src/components/app-wrapper.jsx

📝 Walkthrough

Walkthrough

The PR imports a Yup configuration module early in app startup so its side effects run before any form schemas are created, and removes three Yup-related translation keys from English and French locale files.

Changes

Yup Configuration and Validation Messages

Layer / File(s) Summary
Yup configuration early initialization
src/components/app-wrapper.jsx
The Yup configuration module is imported near the top of the app-wrapper to ensure it runs before form schemas are created.
Deprecated validation message translations removal
src/translations/en.json, src/translations/fr.json
The translation keys YupRequired, YupNotTypeNumber, and YupNotTypeDefault are removed from both English and French translation files.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'init yup config before creating form schemas' accurately reflects the primary change of importing yup-config with proper initialization order in app-wrapper.jsx.
Description check ✅ Passed The description 'remove duplicate translations to use the ones in commons-ui' is related to the changeset, which removes three translation keys from en.json and fr.json files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Comment thread src/components/app-wrapper.jsx Outdated
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/components/app-wrapper.jsx`:
- Line 9: Update the inline comment that currently reads "configuer yup before
creating the form schemas" to correct the typo so it reads "configure yup before
creating the form schemas"; locate that comment in the top of the app wrapper
component (the comment string "configuer yup before creating the form schemas")
and replace the misspelled word only.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b811a40d-c338-4a15-8df8-0fcb9a2eb0d8

📥 Commits

Reviewing files that changed from the base of the PR and between 83f8d4f and 523aca5.

📒 Files selected for processing (3)
  • src/components/app-wrapper.jsx
  • src/translations/en.json
  • src/translations/fr.json
💤 Files with no reviewable changes (2)
  • src/translations/en.json
  • src/translations/fr.json

Comment thread src/components/app-wrapper.jsx Outdated
Comment thread src/components/app-wrapper.jsx Outdated
khouadrired and others added 2 commits May 20, 2026 14:56
Co-authored-by: klesaulnier <42617371+klesaulnier@users.noreply.github.com>
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants