Skip to content

Fix BusMenu : show SC dynamic simulation optionaly #3934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sBouzols wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix BusMenu : show SC dynamic simulation optionaly #3934

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions src/components/menus/bus-menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,8 @@ export const BusMenu: FunctionComponent<BusMenuProps> = ({
const computationStarting = useSelector((state: AppState) => state.computationStarting);

const shortCircuitAvailability = useOptionalServiceStatus(OptionalServicesNames.ShortCircuit);
const dynamicSimulationAvailability = useOptionalServiceStatus(OptionalServicesNames.DynamicSimulation);
console.log('SBO dynamicSimulationAvailability', dynamicSimulationAvailability);
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Remove debug console logging before merge.

Line 111 logs internal runtime state in production paths and will add noise in user consoles. Please remove it (or guard behind a dev-only logger).

Suggested change 
-    console.log('SBO dynamicSimulationAvailability', dynamicSimulationAvailability);
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
console.log('SBO dynamicSimulationAvailability', dynamicSimulationAvailability);
🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/components/menus/bus-menu.tsx` at line 111, Remove the debug console
logging of internal state by deleting the console.log('SBO
dynamicSimulationAvailability', dynamicSimulationAvailability) call in
src/components/menus/bus-menu.tsx (or replace it with a dev-only logger).
Specifically, locate the usage in the component or function that references
dynamicSimulationAvailability and either remove the line or wrap it with an
environment/dev check (e.g., only log when process.env.NODE_ENV !== 'production'
or using your app's debug logger) so production builds no longer emit this
runtime state to the console.

Copy link
Copy Markdown
Contributor

@thangqp thangqp May 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
console.log('SBO dynamicSimulationAvailability', dynamicSimulationAvailability);


const oneBusShortcircuitAnalysisState = useSelector(
(state: AppState) => state.computingStatus[ComputingType.SHORT_CIRCUIT_ONE_BUS]
Expand Down Expand Up @@ -177,14 +179,16 @@ export const BusMenu: FunctionComponent<BusMenuProps> = ({
/>
</CustomMenuItem>
)}
{isDeveloperMode && getEventType(EquipmentType.BUS) && (
<DynamicSimulationEventMenuItem
equipmentId={busId}
equipmentType={EquipmentType.BUS}
onOpenDynamicSimulationEventDialog={handleOpenDynamicSimulationEventDialog}
disabled={!isNodeEditable}
/>
)}
{dynamicSimulationAvailability === OptionalServicesStatus.Up &&
isDeveloperMode &&
getEventType(EquipmentType.BUS) && (
<DynamicSimulationEventMenuItem
equipmentId={busId}
equipmentType={EquipmentType.BUS}
onOpenDynamicSimulationEventDialog={handleOpenDynamicSimulationEventDialog}
disabled={!isNodeEditable}
/>
)}
<CustomMenuItem
sx={styles.menuItem}
onClick={handleClickTrip}
Expand Down
Loading