Refactor global filters: simplify state management by flomillot · Pull Request #3744 · gridsuite/gridstudy-app

flomillot · 2026-02-18T11:39:18Z

PR Summary

The goal of this pull request is to refactor the global filters management, by simplifying and clarifying the storage and the update.
It also resolves some bugs and performance issues.
All the global filter definitions / options are now stored in only one list in Redux.
For each table we have a list with the selected global filters ID.
Redux is now the source of truth. And every update to the backend are now done asynchronously and automatically via a Redux middleware.
Some cleaning, renaming and other simplification have also been done.

- Rework global filter redux state and middleware - Simplify GlobalFilterProvider, GlobalFilterSelector and related hooks - Simplify spreadsheet global filter component - Update computation result tabs (loadflow, security analysis, sensitivity analysis, shortcircuit, pcc-min, voltage-init) to use refactored filters - Adjust column filter hooks and utilities Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>

… improved performance and readability Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>

# Conflicts: # src/components/results/common/column-filter/update-computation-columns-filters.ts # src/components/results/common/column-filter/use-computation-column-filters.ts # src/components/results/loadflow/load-flow-result-tab.tsx # src/components/results/loadflow/load-flow-result-utils.ts # src/components/results/pccmin/pcc-min-result.tsx # src/components/results/securityanalysis/security-analysis-result-tab.tsx # src/components/results/sensitivity-analysis/paged-sensitivity-analysis-result.tsx # src/components/results/shortcircuit/shortcircuit-analysis-result.tsx

Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>

…factor-global-filters

Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>

…factor-global-filters

This reverts commit 954d475.

Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>

ghazwarhili · 2026-02-24T10:23:54Z

src/components/results/common/global-filter/use-selected-global-filters.ts

+ * joins them with the global filter options, and returns the resolved `GlobalFilter[]`.
+ * Use this when you need the selected filters at a T time, e.g. when fetching the data.
+ */
+export function getSelectedGlobalFilters(tableKey: string): GlobalFilter[] {


Remove this function from this hook and move it to the global-filter-utils.ts

I wanted to keep it alongside the hook so that people can read the descriptions and choose which one to use
But ok its legit I will move it

ghazwarhili · 2026-02-24T10:39:50Z

...ts/spreadsheet-view/spreadsheet/spreadsheet-toolbar/row-counter/use-filtered-row-counter.tsx

-    const globalFilterSpreadsheetState = useSelector(
-        (state: AppState) => state.globalFilterSpreadsheetState[tableDefinition.uuid]
-    );
+    const globalFilterSpreadsheetState = useSelectedGlobalFilters(tableDefinition.uuid);


selectedGlobalFilters

I kept the previous variable name to keep the history clean.
It's also coherent with the columns filter variable name.

gridstudy-app/src/components/spreadsheet-view/spreadsheet/spreadsheet-toolbar/row-counter/use-filtered-row-counter.tsx

Lines 48 to 51 in 376f5e4

const globalFilterSpreadsheetState = useSelectedGlobalFilters(tableDefinition.uuid);

const spreadsheetColumnsFiltersState = useSelector(

(state: AppState) => state.spreadsheetFilter[tableDefinition?.uuid]

);

Maybe refactor them later in another pull request ?

ghazwarhili · 2026-02-24T10:48:48Z

src/redux/actions.ts

-    uuid: UUID;
+export const REMOVE_FROM_GLOBAL_FILTER_OPTIONS = 'REMOVE_FROM_GLOBAL_FILTER_OPTIONS';
+export type RemoveFromGlobalFilterOptionsAction = Readonly<Action<typeof REMOVE_FROM_GLOBAL_FILTER_OPTIONS>> & {
+    id: string;


It's not always an UUID

ghazwarhili · 2026-02-24T11:01:03Z

src/redux/reducer.ts

-    builder.addCase(SAVE_SPREADSHEET_GS_FILTER, (state, action: SaveSpreadSheetGlobalFilterAction) => {
-        state.globalFilterSpreadsheetState[action.tabUuid] = action.filters;
+    builder.addCase(INIT_SPREADSHEET_GLOBAL_FILTER, (state, action: InitSpreadSheetGlobalFilterAction) => {
+        console.log('Reducer INIT_SPREADSHEET_GLOBAL_FILTER:', action);


to be removed

Yes, I saw it, I cleaned it.

…ver. Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>

ghazwarhili · 2026-02-24T11:23:46Z

src/redux/globalFiltersMiddleware.ts

+ * This ensures that the server state remains in sync with the client-side filter state from Redux.
+ */
+export const globalFiltersMiddleware: Middleware<{}, AppState> = (store) => (next) => (action) => {
+    const result = next(action); // Let Redux update the state first


ghazwarhili · 2026-02-24T11:26:06Z

src/components/spreadsheet-view/add-spreadsheet/dialogs/add-spreadsheet-utils.ts

    addFilterForNewSpreadsheet,
    addSortForNewSpreadsheet,
-    saveSpreadsheetGlobalFilters,
+    initOrUpdateSpreadsheetGlobalFilters,


Or we can simply keep saveSpreadsheetGlobalFilters

Save is really a database operation. I can use set if you prefer, but I prefer init or update Because it describes precisely what the action do

ghazwarhili · 2026-02-24T11:59:07Z

src/redux/globalFiltersMiddleware.ts

+                    );
+                }
+                delete debouncedSyncTimers[index];
+            }, 2000);


use debounce from '@mui/material' is better than manual setTimeout

This code is outside React and MUI. I prefer manual JavaScript here. Why do you think it's better ?

ghazwarhili · 2026-02-24T12:00:31Z

src/components/results/common/global-filter/global-filter-autocomplete.tsx

-                              : option.filterType === filterGroupSelected
-                    )
-                    .filter((option: GlobalFilter) =>
-                        genericFiltersStrictMode && option.filterType === FilterType.GENERIC_FILTER


why genericFiltersStrictMode is removed from here ?

Moved below where it belongs

ghazwarhili · 2026-02-24T12:01:42Z

src/components/results/common/global-filter/global-filter-autocomplete.tsx

                    disableCloseOnSelect
                    options={options}
-                    onChange={(_e, value) => onChange(value)}
-                    groupBy={(option: GlobalFilter): string =>


we don't need anymore groupBy here ?

Nope it's deprecated code, we discussed about with @Mathieu-Deharbe

ghazwarhili · 2026-02-24T12:03:14Z

src/components/results/common/global-filter/global-filter-paper.tsx

                        element.specificMetadata?.equipmentType === EQUIPMENT_TYPES.SUBSTATION ||
                        element.specificMetadata?.equipmentType === EQUIPMENT_TYPES.VOLTAGE_LEVEL;
                    newlySelectedFilters.push({
+                        id: element.elementUuid,


id and uuid ?

Yes because uuid has another signification here.

ghazwarhili · 2026-02-24T12:05:26Z

src/redux/actions.ts

    | UpdateColumnFiltersAction
-    | UpdateGlobalFiltersAction;
+    | AddGlobalFiltersAction
+    | ClearGlobalFiltersAction;


and RemoveGlobalFiltersAction; ?

Oh yes thanks didnt notice that

…perations and improve performance. Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>

… to `global-filter-utils` and updating imports across components. Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>

sonarqubecloud · 2026-02-24T14:50:12Z

Quality Gate passed

Issues
10 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

flomillot added 2 commits February 18, 2026 12:31

Refactor global filter results hook: add debounce and useCallback for…

8b5cfe2

… improved performance and readability Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>

flomillot mentioned this pull request Feb 18, 2026

Remove unused id field from GlobalFilterInfos DTO gridsuite/study-config-server#101

Merged

flomillot added 8 commits February 18, 2026 15:09

Merge branch 'main' into refactor-global-filters

6022af7

clean code

0dc63e8

Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>

Merge remote-tracking branch 'origin/refactor-global-filters' into re…

cf927f2

…factor-global-filters

Merge branch 'main' into refactor-global-filters

dfd1355

eslint

954d475

Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>

Merge remote-tracking branch 'origin/refactor-global-filters' into re…

8877484

…factor-global-filters

Revert "eslint"

2a87bb3

This reverts commit 954d475.

ghazwarhili self-requested a review February 19, 2026 11:11

flomillot added 3 commits February 19, 2026 12:58

revert pagination

e493a7f

Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>

fix refresh data when computation global filters change.

510f1e6

Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>

restore pagination for computation table global flitters

f92ba58

Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>

basseche self-requested a review February 19, 2026 15:48

flomillot added 3 commits February 20, 2026 16:02

refactor pagination dispatcher and cleanup global filters effect

b37a952

Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>

Merge branch 'main' into refactor-global-filters

1d7e932

remove debug log and reorder action types in global filters middleware

082d28b

Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>

basseche approved these changes Feb 20, 2026

View reviewed changes

flomillot added 2 commits February 20, 2026 17:31

remove unnecessary blank line in global filters middleware

0fc72fd

Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>

Merge branch 'main' into refactor-global-filters

cba89c6

ghazwarhili reviewed Feb 24, 2026

View reviewed changes

Restore the synchronisation of global filters from Redux with the ser…

21fea13

…ver. Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>

ghazwarhili reviewed Feb 24, 2026

View reviewed changes

flomillot added 2 commits February 24, 2026 15:14

Clarify conditions for updating global filters to avoid unnecessary o…

b7cd2df

…perations and improve performance. Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>

Refactor global filter utilities by moving getSelectedGlobalFilters…

9f0bf07

… to `global-filter-utils` and updating imports across components. Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>

flomillot requested a review from ghazwarhili February 24, 2026 14:45

	const globalFilterSpreadsheetState = useSelectedGlobalFilters(tableDefinition.uuid);
	const spreadsheetColumnsFiltersState = useSelector(
	(state: AppState) => state.spreadsheetFilter[tableDefinition?.uuid]
	);

Comments

Conversation

flomillot commented Feb 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flomillot Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Feb 24, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

flomillot commented Feb 18, 2026 •

edited

Loading

flomillot Feb 24, 2026 •

edited

Loading