Open
Conversation
ayolab
force-pushed
the
ayolab/add-workspace-panel-error-boundary
branch
from
8c444b0 to
30031ea
Compare
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
ayolab
force-pushed
the
ayolab/add-workspace-panel-error-boundary
branch
from
30031ea to
2041f1c
Compare
sBouzols
reviewed
Feb 25, 2026
sBouzols
reviewed
Feb 25, 2026
| return ( | ||
| <Box sx={styles.container}> | ||
| <Box sx={styles.centeredContent}> | ||
| <ErrorOutlineIcon sx={styles.icon} /> |
Contributor
There was a problem hiding this comment.
Suggested change
| <ErrorOutlineIcon sx={styles.icon} /> | |
| <ErrorOutlineIcon fontSize='large' color='error' /> |
and remove icon style ?
sBouzols
reviewed
Feb 25, 2026
| container: { | ||
| display: 'flex', | ||
| flexDirection: 'column', | ||
| height: '100%', |
Contributor
There was a problem hiding this comment.
Suggested change
| height: '100%', | |
| flexGrow: 1, |
?
Contributor
There was a problem hiding this comment.
And make the parent Box a flex container ?
sBouzols
reviewed
Feb 25, 2026
sBouzols
reviewed
Feb 25, 2026
Signed-off-by: Ayoub LABIDI <ayoub.labidi@protonmail.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.