Skip to content

Comments

add several limits with line catalog#3739

Open
EtienneLt wants to merge 22 commits intomainfrom
add-limits-in-lines-catalog
Open

add several limits with line catalog#3739
EtienneLt wants to merge 22 commits intomainfrom
add-limits-in-lines-catalog

Conversation

@EtienneLt
Copy link
Contributor

PR Summary

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@EtienneLt EtienneLt self-assigned this Feb 16, 2026
EtienneLt and others added 11 commits February 16, 2026 09:04
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@Mathieu-Deharbe Mathieu-Deharbe self-requested a review February 18, 2026 11:19
Mathieu-Deharbe

This comment was marked as off-topic.

Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
@sonarqubecloud
Copy link

EtienneLt and others added 4 commits February 18, 2026 16:54
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
Signed-off-by: Etienne LESOT <etienne.lesot@rte-france.com>
});
fetchStudyMetadata().then((studyMetadata) => {
// metadata order makes order of temporary limits columns
studyMetadata?.temporaryLimitsNamesForCatalog.forEach((limitName) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

temporaryLimitsNamesForCatalog may be undefined. It definitely will be in the default config.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'?' is missing no ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test but you should have to do that part out of the metadata loop :

base.push({
                        headerName: `${limitName} [A]`,
                        field: limitName,
                        cellRenderer: DefaultCellRenderer,
                    });

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of this the data can't be seen from this interface if temporaryLimitsNamesForCatalog is undefined :
image

Which could be a fine design (if the POs agree) but then when I validate I have data :

image

I think we should ignore the data that are not defined in temporaryLimitsNamesForCatalog OR still load the data and display it.

});
fetchStudyMetadata().then((studyMetadata) => {
// metadata order makes order of temporary limits columns
studyMetadata?.temporaryLimitsNamesForCatalog.forEach((limitName) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test but you should have to do that part out of the metadata loop :

base.push({
                        headerName: `${limitName} [A]`,
                        field: limitName,
                        cellRenderer: DefaultCellRenderer,
                    });


export type LimitSelectedRowData = CurrentLimitHeader & TemporaryLimitSelectedRowData;

export type TemporaryLimitSelectedRowData = Record<string, number | string>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
export type TemporaryLimitSelectedRowData = Record<string, number | string>
export type TemporaryLimitSelectedRowData = Record<string, number | string>;

});
fetchStudyMetadata().then((studyMetadata) => {
// metadata order makes order of temporary limits columns
studyMetadata?.temporaryLimitsNamesForCatalog.forEach((limitName) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of this the data can't be seen from this interface if temporaryLimitsNamesForCatalog is undefined :
image

Which could be a fine design (if the POs agree) but then when I validate I have data :

image

I think we should ignore the data that are not defined in temporaryLimitsNamesForCatalog OR still load the data and display it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants