-
Notifications
You must be signed in to change notification settings - Fork 7
Add services to study-light profile, add depends on #618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
3c353eb
c6d6f60
5b2ba65
56d56d3
99b97fb
55c4cd9
a16a2e1
9578fbc
80463a4
470ab28
0e9b39c
0aa3aa5
e941712
4695f56
f8fa58c
d65d2ea
a74edbe
243f950
8fa9f4e
0a17fb2
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,3 @@ | ||
| version: '4.0' | ||
|
|
||
| services: | ||
| case-server: | ||
| profiles: | ||
|
|
@@ -18,12 +16,20 @@ services: | |
| - ../k8s/resources/common/config/case-server-application.yml:/config/specific/application.yml:Z | ||
| - ../k8s/resources/common/config/common-application.yml:/config/common/application.yml:Z | ||
| depends_on: | ||
| postgres: | ||
| condition: service_healthy | ||
| elasticsearch: | ||
| condition: service_healthy | ||
| s3-storage: | ||
| condition: service_healthy | ||
| rabbitmq: | ||
| condition: service_healthy | ||
| logspout: | ||
| condition: "service_started" | ||
| required: false | ||
|
Comment on lines
18
to
29
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: #!/bin/bash
fd -t f 'case-server-application.ya?ml$' -X rg -n -C2 -i 'rabbit|amqp|spring\.cloud\.stream'Repository: gridsuite/deployment Length of output: 46 🏁 Script executed: #!/bin/bash
# First, let's find the docker-compose file mentioned in the review
find . -name "docker-compose.base.yml" -type fRepository: gridsuite/deployment Length of output: 105 🏁 Script executed: #!/bin/bash
# Look for case-server related files in the repository
fd -t f 'case' | grep -E '(config|application|properties|yaml|yml)' | head -20Repository: gridsuite/deployment Length of output: 626 🏁 Script executed: #!/bin/bash
# Check the docker-compose.base.yml file to understand context
cat docker-compose/docker-compose.base.yml | head -40Repository: gridsuite/deployment Length of output: 1133 🏁 Script executed: #!/bin/bash
# Search for case-server service definition and its depends_on configuration
rg -A 10 "case-server:" docker-compose/ --type yamlRepository: gridsuite/deployment Length of output: 1452 🏁 Script executed: #!/bin/bash
# Read the case-server-application.yml file
cat k8s/resources/common/config/case-server-application.ymlRepository: gridsuite/deployment Length of output: 46 🏁 Script executed: #!/bin/bash
# Also check the common-application.yml to see if rabbitmq is configured there
cat k8s/resources/common/config/common-application.yml | head -100Repository: gridsuite/deployment Length of output: 921 🏁 Script executed: #!/bin/bash
# Search for any rabbitmq or amqp configuration across the k8s config directory
rg -i 'rabbit|amqp|spring\.cloud\.stream' k8s/resources/common/config/Repository: gridsuite/deployment Length of output: 463 🏁 Script executed: #!/bin/bash
# Check the size and content of case-server-application.yml
wc -l k8s/resources/common/config/case-server-application.yml
cat -n k8s/resources/common/config/case-server-application.ymlRepository: gridsuite/deployment Length of output: 122 🏁 Script executed: #!/bin/bash
# Search for spring.cloud.stream bindings in case-server config
rg -i 'spring\.cloud\.stream|binding' k8s/resources/common/config/case-server-application.ymlRepository: gridsuite/deployment Length of output: 46 🏁 Script executed: #!/bin/bash
# Check which services in docker-compose depend on rabbitmq
rg -B5 'condition: service_healthy' docker-compose/docker-compose.base.yml | grep -E '(^\s+[a-z-]+:|rabbitmq)'Repository: gridsuite/deployment Length of output: 1485 🏁 Script executed: #!/antml/bash
# List all services and their rabbitmq dependencies
rg 'rabbitmq:' -B20 docker-compose/ --type yaml | rg -E '^\s+[a-z-]+:|rabbitmq:'Repository: gridsuite/deployment Length of output: 461 🏁 Script executed: #!/bin/bash
# Get all services from docker-compose and their rabbitmq dependency status
rg -A 30 '^\s+[a-z-]+:\s*$' docker-compose/docker-compose.base.yml | rg -E '^\s+[a-z-]+:\s*$|rabbitmq:'Repository: gridsuite/deployment Length of output: 461 🏁 Script executed: #!/bin/bash
# Check which other service configs mention spring.cloud.stream or rabbitmq bindings
find k8s/resources/common/config -name '*application.yml' -type fRepository: gridsuite/deployment Length of output: 993 🏁 Script executed: #!/bin/bash
# Check if there are service-specific spring.cloud.stream configurations
for file in $(find k8s/resources/common/config -name '*application.yml' -type f); do
echo "=== $file ==="
rg -i 'spring\.cloud\.stream|binding' "$file" || echo "No spring.cloud.stream"
doneRepository: gridsuite/deployment Length of output: 1477 🏁 Script executed: #!/bin/bash
# Check the case-import-server config since it also depends on rabbitmq
cat k8s/resources/common/config/case-import-server-application.ymlRepository: gridsuite/deployment Length of output: 46 🏁 Script executed: #!/bin/bash
# Get full docker-compose to identify which services actually use rabbitmq
grep -n "rabbitmq:" docker-compose/docker-compose.base.yml | head -20Repository: gridsuite/deployment Length of output: 222 🏁 Script executed: #!/bin/bash
# Check services that depend on rabbitmq - identify which ones actually need it
awk '/depends_on:/,/restart:/' docker-compose/docker-compose.base.yml | grep -B 20 'rabbitmq:' | grep -E '^\s+[a-z-]+:|rabbitmq:'Repository: gridsuite/deployment Length of output: 1607 Remove or reconsider the case-server is primarily a case storage service proxying S3 + Postgres + Elasticsearch. The hard dependency on RabbitMQ at startup is questionable: no spring.cloud.stream bindings are configured in case-server-application.yml (which is empty), and RabbitMQ is not on the documented startup critical path. A transient RabbitMQ outage will unnecessarily block case-server startup. Either remove this dependency entirely, change it to 🤖 Prompt for AI Agents |
||
| restart: unless-stopped | ||
| environment: | ||
| - JAVA_TOOL_OPTIONS=-Xmx186m #deployment: 768m | ||
| - JAVA_TOOL_OPTIONS=-Xmx186m | ||
| command: > | ||
| --server.port=80 | ||
| --spring.config.additional-location=/config/ | ||
|
|
@@ -41,7 +47,6 @@ services: | |
| - all | ||
| - suite | ||
| - study | ||
| - study-light | ||
| - dynamic-mapping | ||
| - dynamic-simulation | ||
| - import | ||
|
|
@@ -54,19 +59,23 @@ services: | |
| - ../k8s/resources/common/config/common-application.yml:/config/common/application.yml:Z | ||
| restart: unless-stopped | ||
| depends_on: | ||
| postgres: | ||
| condition: service_healthy | ||
| rabbitmq: | ||
| condition: service_healthy | ||
| logspout: | ||
| condition: "service_started" | ||
| required: false | ||
| environment: | ||
| - JAVA_TOOL_OPTIONS=-Xmx576m | ||
| - JAVA_TOOL_OPTIONS=-Xmx384m | ||
| command: --server.port=80 --spring.config.additional-location=/config/ | ||
| sysctls: | ||
| - net.ipv4.ip_unprivileged_port_start=0 # for docker < 20.03.0 | ||
| memswap_limit: 1g | ||
| memswap_limit: 768m | ||
| deploy: | ||
| resources: | ||
| limits: | ||
| memory: 1g | ||
| memory: 768m | ||
|
|
||
| filter-server: | ||
| profiles: | ||
|
|
@@ -86,19 +95,23 @@ services: | |
| - ../k8s/resources/common/config/common-application.yml:/config/common/application.yml:Z | ||
| restart: unless-stopped | ||
| depends_on: | ||
| postgres: | ||
| condition: service_healthy | ||
| rabbitmq: | ||
| condition: service_healthy | ||
| logspout: | ||
| condition: "service_started" | ||
| required: false | ||
| command: --server.port=80 --spring.config.additional-location=/config/ | ||
| sysctls: | ||
| - net.ipv4.ip_unprivileged_port_start=0 # for docker < 20.03.0 | ||
| environment: | ||
| - JAVA_TOOL_OPTIONS=-Xmx576m | ||
| memswap_limit: 1g | ||
| - JAVA_TOOL_OPTIONS=-Xmx384m | ||
| memswap_limit: 768m | ||
| deploy: | ||
| resources: | ||
| limits: | ||
| memory: 1g | ||
| memory: 768m | ||
|
|
||
| user-admin-server: | ||
| profiles: | ||
|
|
@@ -118,6 +131,10 @@ services: | |
| - ../k8s/resources/common/config/common-application.yml:/config/common/application.yml:Z | ||
| restart: unless-stopped | ||
| depends_on: | ||
| postgres: | ||
| condition: service_healthy | ||
| rabbitmq: | ||
| condition: service_healthy | ||
| logspout: | ||
| condition: "service_started" | ||
| required: false | ||
|
|
@@ -149,6 +166,8 @@ services: | |
| - ../k8s/resources/common/config/common-application.yml:/config/common/application.yml:Z | ||
| restart: unless-stopped | ||
| depends_on: | ||
| postgres: | ||
| condition: service_healthy | ||
| logspout: | ||
| condition: "service_started" | ||
| required: false | ||
|
|
@@ -180,6 +199,8 @@ services: | |
| - ../k8s/resources/common/config/common-application.yml:/config/common/application.yml:Z | ||
| restart: unless-stopped | ||
| depends_on: | ||
| postgres: | ||
| condition: service_healthy | ||
| logspout: | ||
| condition: "service_started" | ||
| required: false | ||
|
|
@@ -212,19 +233,21 @@ services: | |
| - ../k8s/resources/common/config/common-application.yml:/config/common/application.yml:Z | ||
| restart: unless-stopped | ||
| depends_on: | ||
| postgres: | ||
| condition: service_healthy | ||
| logspout: | ||
| condition: "service_started" | ||
| required: false | ||
| command: --server.port=80 --spring.config.additional-location=/config/ | ||
| sysctls: | ||
| - net.ipv4.ip_unprivileged_port_start=0 # for docker < 20.03.0 | ||
| environment: | ||
| - JAVA_TOOL_OPTIONS=-Xmx384m | ||
| memswap_limit: 768m | ||
| - JAVA_TOOL_OPTIONS=-Xmx186m | ||
| memswap_limit: 512m | ||
| deploy: | ||
| resources: | ||
| limits: | ||
| memory: 768m | ||
| memory: 512m | ||
|
|
||
| network-store-server: | ||
| profiles: | ||
|
|
@@ -243,19 +266,21 @@ services: | |
| - ../k8s/resources/common/config/common-application.yml:/config/common/application.yml:Z | ||
| restart: unless-stopped | ||
| depends_on: | ||
| postgres: | ||
| condition: service_healthy | ||
| logspout: | ||
| condition: "service_started" | ||
| required: false | ||
| environment: | ||
| - JAVA_TOOL_OPTIONS=-Xmx1086m #deployment: 1408m | ||
| - JAVA_TOOL_OPTIONS=-Xmx768m | ||
| command: --server.port=80 --spring.config.additional-location=/config/ | ||
| sysctls: | ||
| - net.ipv4.ip_unprivileged_port_start=0 # for docker < 20.03.0 | ||
| memswap_limit: 1664m #deployment: 2048m | ||
| memswap_limit: 1280m | ||
| deploy: | ||
| resources: | ||
| limits: | ||
| memory: 1664m #deployment: 2048m | ||
| memory: 1280m | ||
|
|
||
| network-conversion-server: | ||
| profiles: | ||
|
|
@@ -275,19 +300,25 @@ services: | |
| - ../k8s/resources/common/config/network-conversion-server-config.yml:/home/powsybl/.itools/config.yml:Z | ||
| restart: unless-stopped | ||
| depends_on: | ||
| elasticsearch: | ||
| condition: service_healthy | ||
| s3-storage: | ||
| condition: service_healthy | ||
| rabbitmq: | ||
| condition: service_healthy | ||
| logspout: | ||
| condition: "service_started" | ||
| required: false | ||
| environment: | ||
| - JAVA_TOOL_OPTIONS=-Xmx768m #deployment: 1408m | ||
| - JAVA_TOOL_OPTIONS=-Xmx576m | ||
| command: --server.port=80 --spring.config.additional-location=/config/ | ||
| sysctls: | ||
| - net.ipv4.ip_unprivileged_port_start=0 # for docker < 20.03.0 | ||
| memswap_limit: 1280m #deployment: 2048m | ||
| memswap_limit: 1g | ||
| deploy: | ||
| resources: | ||
| limits: | ||
| memory: 1280m #deployment: 2048m | ||
| memory: 1g | ||
|
|
||
| loadflow-server: | ||
| profiles: | ||
|
|
@@ -308,19 +339,23 @@ services: | |
| - ../k8s/resources/common/config/loadflow-server-config.yml:/home/powsybl/.itools/config.yml:Z | ||
| restart: unless-stopped | ||
| depends_on: | ||
| postgres: | ||
| condition: service_healthy | ||
| rabbitmq: | ||
| condition: service_healthy | ||
| logspout: | ||
| condition: "service_started" | ||
| required: false | ||
| environment: | ||
| - JAVA_TOOL_OPTIONS=-Xmx768m #deployment: 1408m | ||
| - JAVA_TOOL_OPTIONS=-Xmx576m | ||
| command: --server.port=80 --spring.config.additional-location=/config/ | ||
| sysctls: | ||
| - net.ipv4.ip_unprivileged_port_start=0 # for docker < 20.03.0 | ||
| memswap_limit: 1792m #deployment: 3072m | ||
| memswap_limit: 1g | ||
| deploy: | ||
| resources: | ||
| limits: | ||
| memory: 1792m #deployment: 3072m | ||
| memory: 1g | ||
|
|
||
| config-server: | ||
| profiles: | ||
|
|
@@ -339,6 +374,11 @@ services: | |
| - ../k8s/resources/common/config/config-server-application.yml:/config/specific/application.yml:Z | ||
| - ../k8s/resources/common/config/common-application.yml:/config/common/application.yml:Z | ||
| restart: unless-stopped | ||
| depends_on: | ||
| postgres: | ||
| condition: service_healthy | ||
| rabbitmq: | ||
| condition: service_healthy | ||
|
Comment on lines
+377
to
+381
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Every other service in this file retains the optional 🔧 Restore logspout ordering depends_on:
postgres:
condition: service_healthy
rabbitmq:
condition: service_healthy
+ logspout:
+ condition: "service_started"
+ required: false(apply analogously to Also applies to: 409-411 🤖 Prompt for AI Agents |
||
| environment: | ||
| - JAVA_TOOL_OPTIONS=-Xmx96m | ||
| command: --server.port=80 --spring.config.additional-location=/config/ | ||
|
|
@@ -366,6 +406,9 @@ services: | |
| - ../k8s/resources/common/config/config-notification-server-application.yml:/config/specific/application.yml:Z | ||
| - ../k8s/resources/common/config/common-application.yml:/config/common/application.yml:Z | ||
| restart: unless-stopped | ||
| depends_on: | ||
| rabbitmq: | ||
| condition: service_healthy | ||
| environment: | ||
| - JAVA_TOOL_OPTIONS=-Xmx96m | ||
| command: --server.port=80 --spring.config.additional-location=/config/ | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Broken in-page anchor
#docker-compose-profiles.The link targets
#docker-compose-profiles, but the section header at line 92 is### Docker-compose with profiles, which GitHub renders as the anchor#docker-compose-with-profiles. As written, the link will scroll to the top of the README.🔧 Fix the anchor
📝 Committable suggestion
🧰 Tools
🪛 markdownlint-cli2 (0.22.1)
[warning] 60-60: Link fragments should be valid
(MD051, link-fragments)
🤖 Prompt for AI Agents