Wars sharedclasspath

docker-compose/multiwar/.env

@@ -0,0 +1,6 @@
+SHOULD_INIT_GEO_DATA=true
+SHOULD_INIT_LINES_CATALOG=true
+
+COMPOSE_PROJECT_NAME=gridstudy
+
+TOMCAT_PORT=12345

docker-compose/multiwar/README.md

@@ -0,0 +1,58 @@
+# WAR Deploy Tool
+
+Generated with little supervision by opus4.6.
+
+Builds GridSuite microservices as WAR files for docker-compose deployment, **without modifying any original source files**.
+
+## How it works
+
+Instead of patching server sources, this tool generates **wrapper Maven projects** that:
+1. Depend on the original server JAR (classes artifact)
+2. Add a generated `SpringBootServletInitializer` class that delegates to the original Application class
+3. Package everything as a WAR with a clean context-path name
+
+```
+Original server (unmodified)          Wrapper project (generated)
+┌─────────────────────────┐          ┌─────────────────────────┐
+│ report-server/          │          │ war-wrappers/report-server/
+│   pom.xml (jar)         │◄─────────│   pom.xml (war)         │
+│   ReportApplication.java│          │   WarInitializer.java   │
+└─────────────────────────┘          └─────────────────────────┘
+         │                                      │
+         ▼                                      ▼
+  gridsuite-report-server.jar          report-server.war
+```
+
+## Quick Start
+
+```bash
+# Build all WARs and prepare for docker-compose
+./wars.sh
+
+# Start the stack
+docker compose up
+```
+
+## Enabling/disabling servers
+
+Edit the `MANIFEST` array in `war-deploy.sh`. Comment lines with `#` to disable:
+
+```bash
+"actions-server|actions-server||..."       # enabled
+#"timeseries-server|timeseries-server||..." # disabled
+```
+
+## Prerequisites
+
+- Java 21+
+- Maven 3.8+
+- Server submodules checked out and buildable in the layout of Gridsuite Aggregator
+
+## Excluded (Boot WebFlux — incompatible(??) with WAR)
+
+- config-server
+- config-notification-server
+- directory-notification-server
+- merge-notification-server
+- study-notification-server
+- gateway

docker-compose/multiwar/SHARED_CLASSLOADING_ISSUES.txt

@@ -0,0 +1,143 @@
+Shared Classloading Issues — WAR Deployment on Single Tomcat
+=============================================================
+
+All 21 Spring Boot microservices deployed as WARs on one Tomcat instance,
+with all dependency JARs in Tomcat's shared lib/ (common classloader).
+Each WAR contains only its own server classes JAR.
+
+ISSUE 1: Bean definition conflicts
+───────────────────────────────────
+Symptom:  BeanDefinitionOverrideException — duplicate bean names from
+          @Configuration classes in gridsuite-computation, gridsuite-network-modification
+          JARs now visible to ALL webapps via common classloader.
+Fix:      -Dspring.main.allow-bean-definition-overriding=true in CATALINA_OPTS.
+
+ISSUE 2: DataSource auto-configuration on non-DB servers
+────────────────────────────────────────────────────────
+Symptom:  "Could not resolve placeholder 'powsybl-ws.database.name'" on
+          explore-server, network-conversion-server, network-map-server.
+Cause:    powsybl-ws-commons JAR in shared lib has application.yaml referencing
+          DB properties. With HikariCP/spring-jdbc on common classpath,
+          DataSourceAutoConfiguration activates for all webapps.
+Fix:      Auto-detect non-DB servers (no JPA/JDBC/Liquibase deps) and add
+          spring.autoconfigure.exclude entries to their externalized configs:
+          DataSourceAutoConfiguration, HibernateJpaAutoConfiguration,
+          LiquibaseAutoConfiguration, DataSourceTransactionManagerAutoConfiguration.
+
+ISSUE 3: Spring Security activating on all servers
+──────────────────────────────────────────────────
+Symptom:  All servers return "Please sign in" login page.
+Cause:    Only explore-server depends on spring-security, but security JARs
+          in shared lib activate SecurityAutoConfiguration for all webapps.
+Fix:      Auto-detect non-security servers (no spring-boot-starter-security or
+          spring-security-config in deps) and add exclusions:
+          SecurityAutoConfiguration, UserDetailsServiceAutoConfiguration,
+          ManagementWebSecurityAutoConfiguration.
+
+ISSUE 4: Logback ConcurrentModificationException during parallel deployment
+───────────────────────────────────────────────────────────────────────────
+Symptom:  ConcurrentModificationException in ContextBase.getCopyOfPropertyMap
+          during startup.
+Cause:    startStopThreads="10" in server.xml → 10 WARs deploy simultaneously,
+          all sharing the same Logback LoggerContext from common classloader.
+          Race condition in property map access.
+Fix:      Set startStopThreads="1" in server.xml for sequential deployment.
+          Shared lib preloads all classes, so sequential is fast enough.
+
+ISSUE 5: ServiceLoader "not a subtype" errors
+──────────────────────────────────────────────
+Symptom:  ServiceConfigurationError: ActivePowerControlLoader not a subtype
+          of ExtensionLoader.
+Cause:    Version mismatch between shared lib (e.g. 1.40.0) and per-WAR
+          override JARs (1.41.0). Different classloaders load the same
+          interface → different type identity → ServiceLoader rejects impl.
+Fix:      Removed per-WAR version overrides entirely. All servers use the
+          highest version from shared lib (sort -k5Vr). No override JARs in
+          WEB-INF/lib/ — only the server's own classes JAR.
+
+ISSUE 6: antlr4 tool JAR conflicts with antlr4-runtime
+───────────────────────────────────────────────────────
+Symptom:  ATN version mismatch errors from Hibernate HQL parser.
+Cause:    org.antlr:antlr4:4.5.1 (parser generator tool) bundles old runtime
+          classes that conflict with antlr4-runtime:4.13.0 used by Hibernate.
+Fix:      Exclude org.antlr:antlr4: (tool JAR) from shared lib via grep filter.
+          antlr4-runtime (the actual dependency) is kept.
+
+ISSUE 7: ResourceBundle not found for reports.properties
+────────────────────────────────────────────────────────
+Symptom:  MissingResourceException: Can't find bundle for base name
+          com.powsybl.network.conversion.server.reports.
+Cause:    MultiBundleMessageTemplateProvider (in powsybl-commons, common CL)
+          calls ResourceBundle.getBundle() without explicit classloader →
+          uses caller's CL (common CL) → can't see .properties files inside
+          each WAR's server JAR in WEB-INF/lib/.
+Fix:      Extract reports*.properties from all 9 server source trees, package
+          into a single resource-bundles.jar in shared lib. All bundle paths
+          are unique (different packages), so no conflicts.
+
+ISSUE 8: Elasticsearch thread pool explosion (441 threads)
+──────────────────────────────────────────────────────────
+Symptom:  706 threads total; 441 are elasticsearch-rest-client I/O threads.
+          21 ES client pools × 21 threads each (one per CPU core).
+Cause:    ElasticsearchRestClientAutoConfiguration activates for ALL 21 webapps
+          because ES client JARs are on the common classpath. Only 5 servers
+          actually use Elasticsearch (case, directory, network-conversion,
+          network-modification, study).
+Fix:      Auto-detect non-ES servers (no elasticsearch/elastic-clients in deps)
+          and add exclusions: ElasticsearchRestClientAutoConfiguration,
+          ElasticsearchClientAutoConfiguration,
+          ReactiveElasticsearchClientAutoConfiguration,
+          ElasticsearchDataAutoConfiguration,
+          ElasticsearchRepositoriesAutoConfiguration.
+          Result: 706 → 456 threads (−250).
+
+ISSUE 9: OpenTelemetry tracing auto-configuration failure
+─────────────────────────────────────────────────────────
+Symptom:  APPLICATION FAILED TO START — OpenTelemetryTracingAutoConfiguration
+          required a bean of type 'io.opentelemetry.api.OpenTelemetry'.
+Cause:    OTel JARs on common classpath activate tracing autoconfigs for all
+          webapps. Each webapp also creates BatchSpanProcessor and
+          BatchLogRecordProcessor threads (42 total) needlessly.
+Fix:      Exclude for all servers (none configure OTel tracing):
+          OpenTelemetryAutoConfiguration (×2 in different packages),
+          OpenTelemetryTracingAutoConfiguration,
+          OtlpAutoConfiguration, OtlpTracingAutoConfiguration,
+          OpenTelemetryLoggingAutoConfiguration.
+
+MEMORY USAGE REPORT (21 webapps, shared classloading)
+======================================================
+Container: 2.5g limit, no swap | JVM: -Xmx1g, G1GC
+
+Docker stats: 2.24 GiB / 2.5 GiB (89%) — 488 threads (PIDs)
+
+NMT committed breakdown (1,619 MB total):
+  Java Heap        1,020 MB   (Xmx 1g, ~300MB used at idle, ~1g under load)
+  Metaspace          193 MB   (43K classes across 21 webapps)
+  GC (G1)             92 MB   (card tables, remembered sets)
+  Code cache           85 MB   (JIT compiled code)
+  Symbol table         71 MB   (interned strings, 582K entries)
+  Threads              51 MB   (488 threads × ~1MB stack)
+  Class metadata       34 MB   (class pointers, vtables)
+  NMT overhead         14 MB
+  Other (CDS, etc.)    59 MB
+
+RSS vs NMT gap (~600 MB):
+  NMT committed = 1,619 MB, docker reports 2,236 MB.
+  Difference is thread stack RSS, glibc malloc arenas, mmap'd JARs,
+  and kernel page table overhead not tracked by NMT.
+
+Comparison vs 21 separate containers:
+  Each server standalone uses ~300-500 MB (avg ~400 MB).
+  21 × 400 MB = 8.4 GB total.
+  Shared classloading: 2.24 GB = ~73% memory reduction.
+
+ISSUE 10: Maven build failures
+─────────────────────────────
+8a) Thread contention: -T2.0C (40 threads on 20 cores) caused Maven lock
+    contention. Fixed: -T4.
+8b) Missing artifact com.bea.xml:jsr173-ri:1.0 (transitive of stax-utils).
+    Fixed: wildcard <exclusions> on all shared-deps POM entries since
+    _shared.txt is already the full transitive closure.
+8c) Empty WARs: packagingExcludes=WEB-INF/lib/*.jar removed everything.
+    maven-war-plugin doesn't support ! negation in packagingExcludes.
+    Fixed: switched to packagingIncludes (whitelist approach).