Conversation
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com> # Conflicts: # package-lock.json # package.json
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
|
📝 WalkthroughWalkthroughThe pull request upgrades Material-UI packages from v5 to v6 across package.json and adjusts component prop types and styling approaches to align with MUI v6 compatibility requirements. Changes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/components/topBar/AboutDialog.tsx (1)
208-214: Optional: migrate deprecatedTransitionComponent/TransitionPropstoslots/slotProps.With the MUI v6 upgrade,
TransitionComponentonTooltip(line 208) andTransitionPropsonDialog(line 346) andAccordion(line 438) are deprecated in favor ofslots.transitionandslotProps.transition. They still work in v6 but emit deprecation warnings and will be removed in v7. Safe to defer, but worth queuing for a follow-up.♻️ Example migration for Dialog
- TransitionProps={{ - onExited: () => { - setModules(null); - setActualGlobalVersion(null); - }, - }} + slotProps={{ + transition: { + onExited: () => { + setModules(null); + setActualGlobalVersion(null); + }, + }, + }}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/components/topBar/AboutDialog.tsx` around lines 208 - 214, Replace deprecated TransitionComponent/TransitionProps uses with the v6 slots/slotProps pattern: for Tooltip (where TransitionComponent={Zoom} and related transition props are set) move to slots={{ transition: Zoom }} and copy any transition props (e.g. enterDelay, enterNextDelay, leaveDelay or timeout) into slotProps={{ transition: { enterDelay: ..., enterNextDelay: ..., leaveDelay: ... } }}; similarly replace Dialog and Accordion TransitionProps by passing slots={{ transition: YourTransition }} and slotProps={{ transition: { ...existingTransitionProps } }} so the same transition component and props are applied via slots/slotProps instead of TransitionComponent/TransitionProps.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@src/components/topBar/AboutDialog.tsx`:
- Around line 208-214: Replace deprecated TransitionComponent/TransitionProps
uses with the v6 slots/slotProps pattern: for Tooltip (where
TransitionComponent={Zoom} and related transition props are set) move to
slots={{ transition: Zoom }} and copy any transition props (e.g. enterDelay,
enterNextDelay, leaveDelay or timeout) into slotProps={{ transition: {
enterDelay: ..., enterNextDelay: ..., leaveDelay: ... } }}; similarly replace
Dialog and Accordion TransitionProps by passing slots={{ transition:
YourTransition }} and slotProps={{ transition: { ...existingTransitionProps } }}
so the same transition component and props are applied via slots/slotProps
instead of TransitionComponent/TransitionProps.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: c8848c00-e8f3-47dc-8602-404054404c04
⛔ Files ignored due to path filters (1)
package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (3)
package.jsonsrc/components/grid/grid-item.tsxsrc/components/topBar/AboutDialog.tsx
|




PR Summary
Upgrade to MUI v6 (but keeping the now deprecated Grid component)