Skip to content

Upgrade to MUI v6#924

Open
FranckLecuyer wants to merge 13 commits intomainfrom
upgrade_to_mui_v6
Open

Upgrade to MUI v6#924
FranckLecuyer wants to merge 13 commits intomainfrom
upgrade_to_mui_v6

Conversation

@FranckLecuyer
Copy link
Copy Markdown
Contributor

PR Summary

Upgrade to MUI v6 (but keeping the now deprecated Grid component)

FranckLecuyer and others added 2 commits November 13, 2025 11:19
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
Comment thread src/components/grid/grid-item.tsx Outdated
achour94 and others added 5 commits November 24, 2025 15:17
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>

# Conflicts:
#	package-lock.json
#	package.json
Signed-off-by: Franck LECUYER <franck.lecuyer@rte-france.com>
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jan 6, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 22, 2026

📝 Walkthrough

Walkthrough

The pull request upgrades Material-UI packages from v5 to v6 across package.json and adjusts component prop types and styling approaches to align with MUI v6 compatibility requirements.

Changes

Cohort / File(s) Summary
Dependency Upgrade
package.json
Updated @mui/icons-material, @mui/lab, and @mui/material from v5 ranges to v6 versions (^6.5.0, 6.0.1-beta.36, ^6.5.0) in both peerDependencies and devDependencies.
MUI v6 Compatibility
src/components/grid/grid-item.tsx, src/components/topBar/AboutDialog.tsx
Adjusted prop types and styling to align with MUI v6; GridItemProps.size type changed from GridSize to GridProps['xs'], and Typography color props converted to sx-based theme styling using mergeSx utility.
🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Upgrade to MUI v6' directly and clearly summarizes the main change across all modified files.
Description check ✅ Passed The description accurately relates to the changeset, explaining the MUI v5 to v6 upgrade and the retention of the deprecated Grid component.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/components/topBar/AboutDialog.tsx (1)

208-214: Optional: migrate deprecated TransitionComponent/TransitionProps to slots/slotProps.

With the MUI v6 upgrade, TransitionComponent on Tooltip (line 208) and TransitionProps on Dialog (line 346) and Accordion (line 438) are deprecated in favor of slots.transition and slotProps.transition. They still work in v6 but emit deprecation warnings and will be removed in v7. Safe to defer, but worth queuing for a follow-up.

♻️ Example migration for Dialog
-            TransitionProps={{
-                onExited: () => {
-                    setModules(null);
-                    setActualGlobalVersion(null);
-                },
-            }}
+            slotProps={{
+                transition: {
+                    onExited: () => {
+                        setModules(null);
+                        setActualGlobalVersion(null);
+                    },
+                },
+            }}
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@src/components/topBar/AboutDialog.tsx` around lines 208 - 214, Replace
deprecated TransitionComponent/TransitionProps uses with the v6 slots/slotProps
pattern: for Tooltip (where TransitionComponent={Zoom} and related transition
props are set) move to slots={{ transition: Zoom }} and copy any transition
props (e.g. enterDelay, enterNextDelay, leaveDelay or timeout) into slotProps={{
transition: { enterDelay: ..., enterNextDelay: ..., leaveDelay: ... } }};
similarly replace Dialog and Accordion TransitionProps by passing slots={{
transition: YourTransition }} and slotProps={{ transition: {
...existingTransitionProps } }} so the same transition component and props are
applied via slots/slotProps instead of TransitionComponent/TransitionProps.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@src/components/topBar/AboutDialog.tsx`:
- Around line 208-214: Replace deprecated TransitionComponent/TransitionProps
uses with the v6 slots/slotProps pattern: for Tooltip (where
TransitionComponent={Zoom} and related transition props are set) move to
slots={{ transition: Zoom }} and copy any transition props (e.g. enterDelay,
enterNextDelay, leaveDelay or timeout) into slotProps={{ transition: {
enterDelay: ..., enterNextDelay: ..., leaveDelay: ... } }}; similarly replace
Dialog and Accordion TransitionProps by passing slots={{ transition:
YourTransition }} and slotProps={{ transition: { ...existingTransitionProps } }}
so the same transition component and props are applied via slots/slotProps
instead of TransitionComponent/TransitionProps.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c8848c00-e8f3-47dc-8602-404054404c04

📥 Commits

Reviewing files that changed from the base of the PR and between cb0f2eb and 429a3ec.

⛔ Files ignored due to path filters (1)
  • package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (3)
  • package.json
  • src/components/grid/grid-item.tsx
  • src/components/topBar/AboutDialog.tsx

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
E Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants