feat(CustomAgGridTable): expose useFieldArray via ref and relax props#1133
feat(CustomAgGridTable): expose useFieldArray via ref and relax props#1133flomillot wants to merge 1 commit into
Conversation
Wrap CustomAgGridTable in forwardRef + useImperativeHandle so parents can drive the underlying field array imperatively (replace/append/...) when their own data flow (e.g. external CSV parsing) needs to load rows into the table. This avoids declaring a second useFieldArray on the same name, which react-hook-form forbids. Also: - Relax the props type: only columnDefs stays required; defaultColDef, pagination, paginationPageSize, alwaysShowVerticalScroll, stopEditingWhenCellsLoseFocus, rowSelection and overrideLocales are now optional. Expose loading as well. - Default stopEditingWhenCellsLoseFocus to true (matches the way every current caller uses it). - Drop the hardcoded rowDragManaged (not compatible with pagination per AG Grid docs) and rowDragEntireRow. Consumers opt into row drag by setting rowDrag: true on a column, which is AG Grid's default drag handle. - Drop the now-redundant stopEditingWhenCellsLoseFocus prop in ExplicitNamingFilterForm. Signed-off-by: Florent MILLOT <75525996+flomillot@users.noreply.github.com>
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
CustomAgGridTableinforwardRef+useImperativeHandleso a parent can drive the internaluseFieldArray(replace,append, ...) without declaring a seconduseFieldArrayon the same name (forbidden by react-hook-form).columnDefsis required.defaultColDef,pagination,paginationPageSize,alwaysShowVerticalScroll,stopEditingWhenCellsLoseFocus,rowSelection,overrideLocalesare now optional.loadingis exposed too.stopEditingWhenCellsLoseFocustotrue(matches every current caller).rowDragManaged(not compatible with pagination per AG Grid docs) androwDragEntireRow. Consumers opt into row drag viarowDrag: trueon a column.stopEditingWhenCellsLoseFocusprop onExplicitNamingFilterForm.Motivated by gridstudy-app's tabular-modification dialog that needs to load CSV-parsed rows imperatively into the grid. Consumer PRs: