Skip to content

fix_pkill #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SviridovMM wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix_pkill #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bin/benchmark-bootstrap.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ CP=${CP}":${SCRIPT_DIR}/../libs/*"
#
# ADD YOUR/CHANGE ADDITIONAL OPTIONS HERE
#
JVM_OPTS="-Xms2g -Xmx2g -server -Djava.net.preferIPv4Stack=true "${JVM_OPTS}
JVM_OPTS="-Djava.net.preferIPv4Stack=true "${JVM_OPTS}
Copy link
Copy Markdown

@anton-vinogradov anton-vinogradov Sep 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems this not related to the issue?

Copy link
Copy Markdown
Author

@SviridovMM SviridovMM Sep 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but this applies to overriding JVM options. They are configured in .properties. Their presence is not justified here.

Copy link
Copy Markdown

@anton-vinogradov anton-vinogradov Sep 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to propose additional PR with this fix.
Let reviewers check one fix per PR.


#
# Assertions are disabled by default.
Expand Down
6 changes: 3 additions & 3 deletions bin/benchmark-servers-stop.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ if [ "${REMOTE_USER}" == "" ]; then
exit 1
fi

pkill -9 -f "benchmark-server-restarter-start.sh"
pkill -f "benchmark-server-restarter-start.sh"

if [[ "${RESTART_SERVERS}" != "true" ]] && [[ "${RESTART_SERVERS}" != "false" ]]; then
echo "<"$(date +"%H:%M:%S")"><yardstick> All server restartets are stopped."
Expand All @@ -82,10 +82,10 @@ for host_name in "${hosts0[@]}";
do
if [[ ${host_name} = "127.0.0.1" || ${host_name} = "localhost" ]]
then
pkill -9 -f "Dyardstick.server"
pkill -f "Dyardstick.server"

else
`ssh -o PasswordAuthentication=no ${REMOTE_USER}"@"${host_name} pkill -9 -f "Dyardstick.server"`
Copy link
Copy Markdown
Contributor

@isuntsov-gridgain isuntsov-gridgain Sep 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SviridovMM if you have promlems with JFR then just set duration in profiler parameters (see below) less than benchmarks duration.

-XX:StartFlightRecording=duration=Ns

Changing the signal for the pkill command can cause problems with hung Java processes.

Copy link
Copy Markdown

@anton-vinogradov anton-vinogradov Sep 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isuntsov-gridgain, could you explain why this change may lead to hanging?

`ssh -o PasswordAuthentication=no ${REMOTE_USER}"@"${host_name} pkill -f "Dyardstick.server"`
fi

echo "<"$(date +"%H:%M:%S")"><yardstick> Server is stopped on "${host_name}
Expand Down