#44 refactor(rosetta): deprecate Rosetta MCP, plugin is the only KB path#45
Open
awrobel-gd wants to merge 1 commit into
Open
#44 refactor(rosetta): deprecate Rosetta MCP, plugin is the only KB path#45awrobel-gd wants to merge 1 commit into
awrobel-gd wants to merge 1 commit into
Conversation
…44) We fully migrated KB init to the bundled Rosetta plugin, leaving the live ims-mcp ("MCP mode") path functionally dead but complicating config, selection, provisioning, and the KB-init prompt. Remove it entirely. Removed: - RosettaKbMode.LIVE_MCP; enum is now DISABLED / PROVISIONED_PLUGIN - Config surface: ROSETTA_MCP_ENABLED, ROSETTA_MCP_COMMAND/ARGS, ROSETTA_SERVER_URL, ROSETTA_API_KEY, ROSETTA_USER_EMAIL, ROSETTA_IMS_VERSION, and the ROSETTA_SERVER_KEY constant - build_rosetta_mcp_config, get_rosetta_kb_tools, _RosettaKbMcpTools, _rosetta_pair - The rosetta/ staging + remap machinery: unpack_rosetta_artifacts, _plugin_mode_active, _ROSETTA_DOT_CLAUDE_SUBDIRS, and both call sites in prepare_parallel_workspaces (only ever did real work in MCP mode) - The KB-init prompt's use_plugin param and its MCP branch (plugin-only now) Kept: ROSETTA_PLUGIN_PATH, ROSETTA_OUTPUT_DIR, provision_rosetta_plugin, setup_rosetta_plugin_env, get_rosetta_plugin_tools, SKIP_MODE mock helpers. Also updated MCP-vs-plugin comments/docstrings, the two agent-facing standards docs (repointed from mcp__KnowledgeBase__* to the provisioned plugin's Skills/subagents), docker-compose.yml, .env.quickstart.example, Dockerfile, specflow-init.sh redaction list, and the current-state config note in agents/IMPLEMENTATION.md. Safety: Settings uses extra="ignore", so leftover ROSETTA_MCP_* env in any deployment is silently ignored rather than crashing startup. Telemetry no longer emits "KnowledgeBase" in mcp_attached_servers. Tests rewritten to the plugin-only contract. 658 unit tests pass; ruff/vulture clean. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
awrobel-gd
force-pushed
the
deprecate-rosetta-mcp
branch
from
4bf8a7f to
e01b4bc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We fully migrated KB init to the bundled Rosetta plugin, leaving the live ims-mcp ("MCP mode") path functionally dead but complicating config, selection, provisioning, and the KB-init prompt. Remove it entirely.
Removed:
Kept: ROSETTA_PLUGIN_PATH, ROSETTA_OUTPUT_DIR, provision_rosetta_plugin, setup_rosetta_plugin_env, get_rosetta_plugin_tools, SKIP_MODE mock helpers.
Also updated MCP-vs-plugin comments/docstrings, the two agent-facing standards docs (repointed from mcp__KnowledgeBase__* to the provisioned plugin's Skills/subagents), docker-compose.yml, .env.quickstart.example, Dockerfile, specflow-init.sh redaction list, and the current-state config note in agents/IMPLEMENTATION.md.
Safety: Settings uses extra="ignore", so leftover ROSETTA_MCP_* env in any deployment is silently ignored rather than crashing startup. Telemetry no longer emits "KnowledgeBase" in mcp_attached_servers. Tests rewritten to the plugin-only contract. 658 unit tests pass; ruff/vulture clean.