fix(model-routing): remove "api error" from routing-failure patterns#36
Merged
Merged
Conversation
…atterns "api error" matched any API Error message regardless of cause, including genuine HTTP errors. Keep "malformed response" / "empty response" as the specific fragments for the OpenRouter malformed-200 failure mode.
awrobel-gd
approved these changes
Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"api error"entry from_MODEL_ROUTING_FAILURE_PATTERNSinbackend/app/services/model_routing.py— it matched anyAPI Errormessage regardless of cause, including genuine HTTP errors, and is superseded by the more specific"malformed response"/"empty response"fragments.backend/test/test_classify_error.pyto reflect the new contract: a bare"api error"message no longer classifies asMODEL_ROUTING_FAILURE.Test plan
make unit-testspasses (backend + mcp_server)