Merged
Conversation
Contributor
|
Hi @andig, thanks for forwarding the PR. Just to understand your intend first. You want to register the logrus Logger implementation at the library, correct? Would the following code snipped already be sufficient for your purpose? handler := modbus.NewTCPClientHandler(address)
handler.Logger = log.New(logrus.New().Writer(), "your prefix ", log.LstdFlags) |
Contributor
Author
|
or whatever the client wants to do. Or I could inject any other object that implements Printf. Without changing anything really its already decoupled from golang log implementation. |
gq0
approved these changes
Oct 18, 2018
Contributor
gq0
left a comment
There was a problem hiding this comment.
I see your point here. Only Printf is required across the repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrated from goburrow/modbus#33