Open
Conversation
z0w13
force-pushed
the
fix/flakey-ratelimiter-tests
branch
from
4e099d4 to
c6d879c
Compare
Contributor
Author
|
I've also encountered some other bugs (and unimplemented tests, we must've been tired) when I revisited this, so fixed that too |
Contributor
Author
|
Hmm, it's causing errors in the test github action, so hold off while we figure that out |
z0w13
force-pushed
the
fix/flakey-ratelimiter-tests
branch
from
e0e256d to
c219126
Compare
z0w13
force-pushed
the
fix/flakey-ratelimiter-tests
branch
from
c219126 to
c581bd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ratelimiter tests sometimes failed because the way they were implemented was inconsistent.
As far as I've been able to test this resolves that issue