Skip to content

fix #5: Retrying with the previous day's image if no data is found for today. #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trumpetx wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix #5: Retrying with the previous day's image if no data is found for today. #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 20 additions & 5 deletions MMM-APOD.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,21 +152,35 @@ Module.register("MMM-APOD",{
},

// Request new data from api.nasa.gov
updateAPOD: async function() {
updateAPOD: async function(daysAgo) {
if(this.config.appid === "") {
Log.error(this.name + ": APPID not set.");
return;
}

var url = this.config.apiBase + this.config.apodEndpoint + "?api_key=" + this.config.appid;
daysAgo = daysAgo || 0;
if(daysAgo > 0) {
const queryDate = new Date();
queryDate.setTime(queryDate.getTime() - 24*60*60*1000*daysAgo);
const queryDateString = `${queryDate.getFullYear()}-${String(queryDate.getMonth() + 1).padStart(2, '0')}-${String(queryDate.getDate()).padStart(2, '0')}`;
Log.info(`Querying from ${queryDateString}`);
url = `${url}&date=${queryDateString}`;
}

var self = this;
var retry = true;

try {
const response = await fetch(url);
if(response.status === 200) {
const data = await response.json();
self.processAPOD(data);
if(!self.processAPOD(data)) {
retry = false;
if(daysAgo > 6) {
throw new Error(`${self.name}: Unable to find an image in the last ${daysAgo} days, check the NASA API: ${url}`);
}
await self.updateAPOD(daysAgo + 1);
}
} else if(response.status === 403) {
self.updateDom(self.config.animationSpeed);
retry = false;
Expand All @@ -191,7 +205,7 @@ Module.register("MMM-APOD",{
processAPOD: function(data) {
if(!data || typeof data.url === "undefined") {
Log.error(this.name + ": Do not receive usable data.");
return;
return false;
}

this.title = data.title;
Expand All @@ -211,11 +225,12 @@ Module.register("MMM-APOD",{
this.url = "https://img.youtube.com/vi/" + id + "/maxresdefault.jpg";
} else {
Log.error(this.name + ": Type of media unknown (not image or video).");
return;
return false;
}

this.loaded = true;
this.updateDom(this.config.animationSpeed);
return true;
},

// Schedule next update
Expand Down