Fix broken LIMIT clause in query templates.#4
Open
lmwnshn wants to merge 1 commit intogregrahn:masterfrom
Open
Fix broken LIMIT clause in query templates.#4lmwnshn wants to merge 1 commit intogregrahn:masterfrom
lmwnshn wants to merge 1 commit intogregrahn:masterfrom
Conversation
Because qgen is essentially a find-and-replace, it was outputting PostgreSQL SQL like
```
order by
l_returnflag, l_linestatus;
limit -1;
order by
revenue desc;
limit 20;
```
which has the following problems:
1. negative limits don't make sense and are unsupported in most DBMSs,
2. the limit clause is not attached to the select.
|
Would be nice to merge this to master @gregrahn.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
qgenis essentially a find-and-replace, it was outputting PostgreSQL SQL likewhich has the following problems:
I have not tested this behavior with the other DBMSs in
tpcd.h, although a number of those seem to be outdated anyway (e.g.,SQLSERVERshould useTOPinstead ofrowcountnow).