Add: Credential stores support

[robindittmar]

What

Add support for credential stores

Why

Support new feature in python-gvm

References

GEA-1261

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA b8ce297.

Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

Scanned Files

None

[greenbonebot]

Scanning the following files:

gvm/protocols/gmp/_gmpnext.py
gvm/protocols/gmp/requests/next/__init__.py
gvm/protocols/gmp/requests/next/_credential_stores.py
gvm/protocols/gmp/requests/next/_credentials.py
tests/protocols/gmpnext/entities/credential_stores/__init__.py
tests/protocols/gmpnext/entities/credential_stores/test_get_credential_stores.py
tests/protocols/gmpnext/entities/credential_stores/test_modify_credential_stores.py
tests/protocols/gmpnext/entities/credential_stores/test_verify_credential_stores.py
tests/protocols/gmpnext/entities/credentials/__init__.py
tests/protocols/gmpnext/entities/credentials/test_create_credential_store_credential.py
tests/protocols/gmpnext/entities/credentials/test_modify_credential_store_credential.py
tests/protocols/gmpnext/entities/test_credential_stores.py
tests/protocols/gmpnext/entities/test_credentials.py

Scan: 'gvm/protocols/gmp/_gmpnext.py'

Nothing detected in gvm/protocols/gmp/_gmpnext.py
Scan took 0.00 seconds

Scan: 'gvm/protocols/gmp/requests/next/init.py'

Nothing detected in gvm/protocols/gmp/requests/next/init.py
Scan took 0.00 seconds

Scan: 'gvm/protocols/gmp/requests/next/_credential_stores.py'

Nothing detected in gvm/protocols/gmp/requests/next/_credential_stores.py
Scan took 0.00 seconds

Scan: 'gvm/protocols/gmp/requests/next/_credentials.py'

Nothing detected in gvm/protocols/gmp/requests/next/_credentials.py
Scan took 0.00 seconds

Scan: 'tests/protocols/gmpnext/entities/credential_stores/init.py'

Nothing detected in tests/protocols/gmpnext/entities/credential_stores/init.py
Scan took 0.00 seconds

Scan: 'tests/protocols/gmpnext/entities/credential_stores/test_get_credential_stores.py'

Nothing detected in tests/protocols/gmpnext/entities/credential_stores/test_get_credential_stores.py
Scan took 0.00 seconds

Scan: 'tests/protocols/gmpnext/entities/credential_stores/test_modify_credential_stores.py'

Nothing detected in tests/protocols/gmpnext/entities/credential_stores/test_modify_credential_stores.py
Scan took 0.00 seconds

Scan: 'tests/protocols/gmpnext/entities/credential_stores/test_verify_credential_stores.py'

Nothing detected in tests/protocols/gmpnext/entities/credential_stores/test_verify_credential_stores.py
Scan took 0.00 seconds

Scan: 'tests/protocols/gmpnext/entities/credentials/init.py'

Nothing detected in tests/protocols/gmpnext/entities/credentials/init.py
Scan took 0.00 seconds

Scan: 'tests/protocols/gmpnext/entities/credentials/test_create_credential_store_credential.py'

Nothing detected in tests/protocols/gmpnext/entities/credentials/test_create_credential_store_credential.py
Scan took 0.00 seconds

Scan: 'tests/protocols/gmpnext/entities/credentials/test_modify_credential_store_credential.py'

Nothing detected in tests/protocols/gmpnext/entities/credentials/test_modify_credential_store_credential.py
Scan took 0.00 seconds

Scan: 'tests/protocols/gmpnext/entities/test_credential_stores.py'

Nothing detected in tests/protocols/gmpnext/entities/test_credential_stores.py
Scan took 0.00 seconds

Scan: 'tests/protocols/gmpnext/entities/test_credentials.py'

Nothing detected in tests/protocols/gmpnext/entities/test_credentials.py
Scan took 0.00 seconds

[github-actions]

Conventional Commits Report

Type	Number
Added	1

🚀 Conventional commits found.

[codecov]

Codecov Report

❌ Patch coverage is 98.47328% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.27%. Comparing base (f9077c5) to head (b8ce297).
⚠️ Report is 13 commits behind head on main.

Files with missing lines	Patch %	Lines
gvm/protocols/gmp/requests/next/_credentials.py	96.49%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##             main    #1274    +/-   ##
========================================
  Coverage   98.26%   98.27%            
========================================
  Files          87       89     +2     
  Lines        6059     6189   +130     
  Branches     1081     1111    +30     
========================================
+ Hits         5954     6082   +128     
- Misses         75       76     +1     
- Partials       30       31     +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[bjoernricks]

Could you please add tests too?

[bjoernricks]

Maybe we should split credential and credential store? Having a dedicated type enum for both and separated methods. CredentialStoreType and create_credential_store_credential or similar? For me create_credential has to many arguments. Same for modify_credential.

[bjoernricks]

I am not 100 percent sure about the details. Could you check other methods how we handle them for the single get use case?