Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #302 +/- ##
==========================================
+ Coverage 96.60% 96.83% +0.22%
==========================================
Files 7 9 +2
Lines 1619 1893 +274
Branches 47 52 +5
==========================================
+ Hits 1564 1833 +269
- Misses 43 47 +4
- Partials 12 13 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bjoernricks
force-pushed
the
improved-settings
branch
from
8733632 to
025921b
Compare
Create a struct that stores all settings.
All functions belonging to the settings should be easily identifiable.
Both guest username and password are not used anymore.
The function is not used and even not implemented.
Make the gsad_settings function more flexible by allowing to work on arbitrary gsad_settings_t pointers.
With this change the global settings are created when calling gsad_settings_get_global_settings() for the first time and afterwards the same pointer is returned always.
bjoernricks
force-pushed
the
improved-settings
branch
from
025921b to
62d7a90
Compare
ozgen
previously approved these changes
Feb 6, 2026
If the global setting is used name the variable after it.
bjoernricks
force-pushed
the
improved-settings
branch
from
7a9f4fa to
cfa459e
Compare
ozgen
previously approved these changes
Feb 9, 2026
ozgen
approved these changes
Feb 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Improve the settings module with namespaced function names and store all settings in a struct.
Why
Better encapsulation of gsad's settings.
Checklist