Skip to content

[S90-JAVA] Avoid use of static in interface#7

Closed
dedece35 wants to merge 1 commit intomainfrom
S90-JAVA
Closed

[S90-JAVA] Avoid use of static in interface#7
dedece35 wants to merge 1 commit intomainfrom
S90-JAVA

Conversation

@dedece35
Copy link
Copy Markdown
Member

@dedece35 dedece35 commented Dec 5, 2022

initial PR (before migration): https://github.com/cnumr/ecoCode/pull/183
(plop @ggeoffroy68 )

@dedece35 dedece35 added 🚀 enhancement New feature or request 🗃️ rule rule improvment or rule development or bug java labels Dec 5, 2022
@dedece35 dedece35 marked this pull request as draft December 5, 2022 14:48
@dedece35
Copy link
Copy Markdown
Member Author

dedece35 commented Dec 13, 2022

Hi @ggeoffroy68,
I checked SonarQube native rules. I found rule with id java:S1214 which deals with the same subject.

Does a documention or tests exist to prove the rightness of your rule ?

please correct conflicts.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jul 1, 2023

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions Bot added the stale label Jul 1, 2023
@dedece35
Copy link
Copy Markdown
Member Author

dedece35 commented Dec 29, 2023

to discuss in core-team :

  • no scientific paper to prove this rule
  • no argument to prove it's a "green" rule
  • there is already a native Sonarqube rule to deal with this rule approximatively ("java:S1214")

for me, rule not acceptable like that.
do we refuse this rule ?

@jhertout
Copy link
Copy Markdown
Contributor

jhertout commented Jan 3, 2024

Hello,

difficult for me to validate a rule like this without a minimum of justification. This requires at least some benchmark. May be we should keep it in mind for the future hackathon since I think it is quite easy to perform measures on a rule like this if we have the tools.

@dedece35
Copy link
Copy Markdown
Member Author

Hi @ggeoffroy68,

sorry but with implementation is that situation, we can't accept this implementation because :

  • no scientific paper to prove this rule
  • no measures to prove it's a "green" rule
  • there is already a native Sonarqube rule to deal with this rule approximatively ("java:S1214")

We keep this proposition to measure it when we will have a tool to measure it.
(check RULES.md )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🗃️ rule rule improvment or rule development or bug java

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants