Skip to content

refactor(demo): Covert auth to standalone#4305

Merged
damienwebdev merged 2 commits intodevelopfrom
refactor/demo/auth
Apr 9, 2026
Merged

refactor(demo): Covert auth to standalone#4305
damienwebdev merged 2 commits intodevelopfrom
refactor/demo/auth

Conversation

@joannalauu
Copy link
Copy Markdown
Contributor

PR Checklist

  • Commit message follows our contributing guidelines
  • Tests added/updated (for bug fixes/features)
  • Documentation added/updated (for bug fixes/features)

PR Type

  • Bug fix
  • Feature
  • Style update
  • Refactor
  • Test
  • Build
  • CI
  • Docs
  • Performance
  • Other (please describe)

Current behavior

Fixes: #
Part of: #3664

New behavior

Auth in demo app is now standalone. Modules have been removed.

Breaking change?

  • Yes
  • No

Additional context

@joannalauu joannalauu requested review from a team as code owners January 27, 2026 19:11
Comment thread apps/demo/src/app/auth/auth-state.provider.ts Outdated
Co-authored-by: Peter Ashwood <griest024@gmail.com>
@joannalauu joannalauu requested a review from griest024 April 8, 2026 20:47
Copy link
Copy Markdown
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev
Copy link
Copy Markdown
Member

The failed build here is just because this hasn't been rebased against develop in a while. Regardless code LGTM.

@damienwebdev damienwebdev merged commit 40bf56a into develop Apr 9, 2026
6 of 7 checks passed
@damienwebdev damienwebdev deleted the refactor/demo/auth branch April 9, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants