Skip to content

feat(driver)!: add feature support to magento driver provider#4251

Merged
griest024 merged 6 commits intograycoreio:developfrom
griest024:feat/driver/magento/add-feature-support-to-provbider
Mar 30, 2026
Merged

feat(driver)!: add feature support to magento driver provider#4251
griest024 merged 6 commits intograycoreio:developfrom
griest024:feat/driver/magento/add-feature-support-to-provbider

Conversation

@griest024
Copy link
Copy Markdown
Member

@griest024 griest024 commented Dec 10, 2025

PR Checklist

  • Commit message follows our contributing guidelines
  • Tests added/updated (for bug fixes/features)
  • Documentation added/updated (for bug fixes/features)

PR Type

  • Bug fix
  • Feature
  • Style update
  • Refactor
  • Test
  • Build
  • CI
  • Docs
  • Performance
  • Other (please describe)

New behavior

makes provideMagentoDriver configable with features

Breaking change?

  • Yes
  • No

Additional context

@griest024 griest024 requested a review from a team as a code owner December 10, 2025 15:16
Copy link
Copy Markdown
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change against @daffodil/commerce.

See: https://github.com/graycoreio/daffodil/blob/develop/tools/schematics/ng-add/generators/providers/standalone.ts#L140

We'll need to adjust this usage and validate that @daffodil/commerce 's Magento schematic works as expected.

@griest024
Copy link
Copy Markdown
Member Author

This is a breaking change against @daffodil/commerce.

See: https://github.com/graycoreio/daffodil/blob/develop/tools/schematics/ng-add/generators/providers/standalone.ts#L140

We'll need to adjust this usage and validate that @daffodil/commerce 's Magento schematic works as expected.

ah yes we should really have test cases for this: #4253

@griest024 griest024 changed the title feat(driver): add feature support to magento driver provider feat(driver)!: add feature support to magento driver provider Dec 10, 2025
@griest024 griest024 requested a review from a team as a code owner December 10, 2025 20:38
@griest024
Copy link
Copy Markdown
Member Author

@damienwebdev should be fixed now

@griest024 griest024 added the status: pending review This PR is awaiting review or response from a reviewer before the author can proceed. label Dec 11, 2025
@griest024 griest024 force-pushed the feat/driver/magento/add-feature-support-to-provbider branch from b408444 to ff6aa43 Compare January 7, 2026 23:09
@griest024 griest024 added the p1 critical priority label Feb 19, 2026
@griest024
Copy link
Copy Markdown
Member Author

@damienwebdev bump

@damienwebdev damienwebdev force-pushed the feat/driver/magento/add-feature-support-to-provbider branch from ff6aa43 to 61866d9 Compare March 8, 2026 17:30
@damienwebdev
Copy link
Copy Markdown
Member

@griest024 I rebased on this @joannalauu 's work from #4342 figured this would be a good smoke test of the new commerce schematics in CI.

@damienwebdev damienwebdev force-pushed the feat/driver/magento/add-feature-support-to-provbider branch from 61866d9 to 3b0d4bf Compare March 10, 2026 15:10
@griest024 griest024 force-pushed the feat/driver/magento/add-feature-support-to-provbider branch from 3b0d4bf to 9bd880f Compare March 11, 2026 19:42
@griest024
Copy link
Copy Markdown
Member Author

@griest024 I rebased on this @joannalauu 's work from #4342 figured this would be a good smoke test of the new commerce schematics in CI.

it was! It found a bug 👍

Copy link
Copy Markdown
Member

@damienwebdev damienwebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@damienwebdev damienwebdev self-requested a review March 30, 2026 15:07
@griest024 griest024 merged commit cff479e into graycoreio:develop Mar 30, 2026
51 checks passed
@gray-bot gray-bot mentioned this pull request Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1 critical priority status: pending review This PR is awaiting review or response from a reviewer before the author can proceed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants