Conversation
xelaint
requested changes
Sep 30, 2025
xelaint
added
status: needs response
xelaint
force-pushed
the
pr/featexternal-router-clarify-readme-and-getting-sta-c3e078e4
branch
from
28e6bfd to
0cc9a87
Compare
xelaint
approved these changes
Mar 10, 2026
damienwebdev
deleted the
pr/featexternal-router-clarify-readme-and-getting-sta-c3e078e4
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Current behavior
I tried to set up the external router driver by following the docs and I was a little confused, so I had to look at the code to remember how it worked.
Touches: #2683
New behavior
I rewrote the guide to be a little more clear on how to use the package.
Breaking change?
Additional context