feat(core): allow independent registration and override of node/mark specs in extensions#990
Draft
feat(core): allow independent registration and override of node/mark specs in extensions#990
Conversation
|
|
|
|
…specs in extensions
d3m1d0v
force-pushed
the
upd-extension-builder
branch
from
fed0b73 to
90f79f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
addNode/addMarkbundle schema spec, parser spec, and serializer spec into a single callback, making it impossible for one extension to incrementally modify another — the only option was full replacement.This PR adds granular registration and override methods to
ExtensionBuilder:New add methods:
addNodeSpec,addMarkSpec— register ProseMirror schema specs independentlyaddMarkdownTokenParserSpec— register markdown-it token → PM entity mappingaddNodeSerializerSpec,addMarkSerializerSpec— register serializer specsNew override methods:
overrideNodeSpec,overrideMarkSpec— modify previously registered schema specsoverrideMarkdownTokenParserSpec— modify parser token specs (works with bothaddNodeand granular API)overrideNodeSerializerSpec,overrideMarkSerializerSpec— modify serializer specsaddNodeandaddMarkmethods are marked as@deprecated.