Conversation
|
JoviDeCroock
left a comment
There was a problem hiding this comment.
Let's change line 55 to also have a pinned version of 0.11
|
The latest changes of this PR are not available as canary, since there are no linked |
Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
trevor-scheer
left a comment
There was a problem hiding this comment.
Thanks for the fix @martinbonnin!
There are a couple other examples that could use the same treatment, would you mind updating them as well?
https://github.com/graphql/graphiql/blob/main/packages/graphiql-plugin-code-exporter/example/index.html
https://github.com/graphql/graphiql/blob/main/packages/graphiql-plugin-explorer/example/index.html
|
Oh wow, blast from the past, I'll try to do this! |
|
@trevor-scheer I have pinned all the versions I could find. Hope that's OK! |
For people like me that are just copy/pasting the sample, it'll avoid breaking when the next GraphiQL breaking release is made. Thanks @JoviDeCroock for the heads up ❤️