-
Notifications
You must be signed in to change notification settings - Fork 3
Update java driver #7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
geequel-shell/src/main/java/org/neo4j/shell/log/NullLogger.java
Outdated
Show resolved
Hide resolved
geequel-shell/src/test/java/org/neo4j/shell/state/BoltStateHandlerTest.java
Outdated
Show resolved
Hide resolved
geequel-shell/src/test/java/org/neo4j/shell/test/bolt/FakeDriver.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
| public Session session(AccessMode accessMode, String bookmark) { | ||
| return new FakeSession(); | ||
| } | ||
| public Session session() { | ||
| return new FakeSession(); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not actually certain about the indentation here. It's possible you want to add one more space...
|
In principle, at least That said, it doesn't look like this project has really published independent packages (and it doesn't look like ongdb has published debian packages either). |
|
@jsoref I think a bump to 2.x likely makes sense as well. For now, we could route these changes to a 1.1 branch and then make that call when we're closer to release time. What do you think about that? |
|
I'm fine w/ that... |
Using newer java driver allows us to use neo4j:// protocol with ONgDB 1.1 to route to WRITE node
Not compatible with ONgDB 1.0.6