Skip to content

Conversation

@SpecialThing44
Copy link
Contributor

@SpecialThing44 SpecialThing44 commented Aug 19, 2025

Using newer java driver allows us to use neo4j:// protocol with ONgDB 1.1 to route to WRITE node

Not compatible with ONgDB 1.0.6

SpecialThing44 and others added 3 commits August 19, 2025 15:37
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Co-authored-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Comment on lines -97 to +88
public Session session(AccessMode accessMode, String bookmark) {
return new FakeSession();
}
public Session session() {
return new FakeSession();
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not actually certain about the indentation here. It's possible you want to add one more space...

@jsoref
Copy link
Contributor

jsoref commented Aug 19, 2025

In principle, at least packaging/debian/changelog should be changed and the version for this project should go from 1.0.x to 2.0.0 as part of this. (Debian versioning expects that an incompatible package have a major version bump, and "Not compatible with ONgDB 1.0.6" would be that.)

That said, it doesn't look like this project has really published independent packages (and it doesn't look like ongdb has published debian packages either).

@bradnussbaum
Copy link
Contributor

@jsoref I think a bump to 2.x likely makes sense as well. For now, we could route these changes to a 1.1 branch and then make that call when we're closer to release time. What do you think about that?

@jsoref
Copy link
Contributor

jsoref commented Aug 21, 2025

I'm fine w/ that...

@bradnussbaum bradnussbaum changed the base branch from 1.0 to 1.1 August 21, 2025 15:09
@bradnussbaum bradnussbaum merged commit e968529 into 1.1 Aug 21, 2025
2 checks passed
@bradnussbaum bradnussbaum deleted the update-java-driver branch August 21, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants