Skip to content

fix: prevent sort filter from flipping direction to DESC after using the pagination #2588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Giovanni-Schroevers wants to merge 1 commit into
base: canary
Choose a base branch
from
Open

fix: prevent sort filter from flipping direction to DESC after using the pagination #2588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/puny-hounds-stare.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@graphcommerce/magento-product': patch
---

Prevent sort filter from flipping direction to DESC after using the pagination
2 changes: 1 addition & 1 deletion packages/magento-product/hooks/useProductListLink.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ export function productListLinkFromFilter(props: ProductFilterParams): string {
// todo(paales): How should the URL look like with multiple sorts?
// Something like: /sort/position,price/dir/asc,asc
if (sort) query += `/sort/${sort}`
if (dir) query += '/dir/desc'
if (dir === 'DESC') query += '/dir/desc'
if (pageSize) query += `/page-size/${pageSize}`

// Apply filters
Expand Down
Loading