Conversation
…D of master. Tested that classic scripts all still produce expected output, ran pytest, and updated (currently private) EAPS testing Python script repo to leverage the wrapper to ensure test_all_graphs.py and edge_deletion_analysis.py both produce the same OK/NONEMBEDDABLE results for N=6,10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #37
Type of change
Please check only relevant options:
Changes
Added
Updated
planarity/c/graphLib/- Updated to reflectc/graphLib/of current EAPSHEADofmasterplanarity/classic/cplanarity.pxd-gp_IsArc()now takes thegraphPas well as the vertex indexplanarity.pyx- updated calls togp_IsArc()with the first parameter being thegraphPassociated with the CythonPGraphobject.planarity.c- rebuilt on MacOS Tahoe 26.3.1 using Cython 3.2.4 withclang22.1.1planarity/full/cg6IterationDefs.pxd- updated function names to reflect changes to thegraphLibcgraphLib.pxd- updated function and macro names and parameterization to reflect changes to thegraphLibg6IterationUtils.pyx- updatedG6(Read|Write)IteratorCython classes so that method names match the CgraphLibfunction names. Note also that we no longer end iteration before freeing (i.e. removed redundant behaviour in thegraphLib).graph.pyx- UpdatedGraphCython class so that method names match the CgraphLibfunction/macro names (taking care to ensure the right macros are being used due to the distinction of Principal Vertices vs. Virtual Vertices vs. Any Type Vertices), and updated the arguments passed down to the C layer. Also refined error messages.g6IterationUtils.candgraph.c- rebuilt on MacOS Tahoe 26.3.1 using Cython 3.2.4 withclang22.1.1Removed
Testing
pytest tests/test_all_graphs.pyandedge_deletion_analysis.pyboth produce the sameOK/NONEMBEDDABLEresults forN=6,10.numInvalidOKscounts forTesting classic subpackage functionality
Running
examples/scripts:pytestresults:Zip files of tables vs. prior version of
graphLib:tables.zip
tables-old.zip