fix: retain proposer attestation data#78
Merged
ArtiomTr merged 1 commit intograndinetech:devnet-3from Mar 12, 2026
Merged
Conversation
ArtiomTr
approved these changes
Mar 12, 2026
Collaborator
ArtiomTr
left a comment
ArtiomTr
left a comment
There was a problem hiding this comment.
nice catch! thank you for the contribution
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes log warning:
WARN validator: Could not find attestation data for aggregation group data_root=...found in lean/lean_client/validator/src/lib.rs maybe_aggregate
This log comes up when the client is an aggregator and propagates for every proposer_attestation_root in every slot where the client is an aggregator. For current devnet-3 testing in lean-quickstart the log continues to grow per slot until by slot 1000 the log message for slot 1000 is ~700 lines long and so on. After the fix all slot logs average around ~50 lines improving readability
The fix is to make the on_block() behavior in line with leanspec where both the proposer_attestation_root and actual proposer_attestation data are stored as opposed to just storing the proposer_attestation_root
https://github.com/leanEthereum/leanSpec/blob/main/src/lean_spec/subspecs/forkchoice/store.py
line 613-616:
sig = signed_block_with_attestation.signature.proposer_signature new_gossip_sigs.setdefault(proposer_attestation.data, set()).add( GossipSignatureEntry(proposer_attestation.validator_id, sig) )