-
Notifications
You must be signed in to change notification settings - Fork 8
feat: Implement persistent storage #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
SoarinSkySagar
wants to merge
11
commits into
grandinetech:devnet-5
Choose a base branch
from
SoarinSkySagar:feature/database
base: devnet-5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,122
−15
Draft
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
6acb243
feat: init database crate
SoarinSkySagar 19c6afd
chore: pull database as a grandine dep and create storage crate
SoarinSkySagar 57d0438
feat: add leanspec consts for db
SoarinSkySagar e0233e0
feat: add databases for each KV pair defined in spec
SoarinSkySagar 4376cdd
feat: add Storage impl with builderplate functions from spec
SoarinSkySagar 2a25e9e
feat: storage spec API functions
SoarinSkySagar efe3e0a
feat: implement libmdbx with custom compression per database instance
SoarinSkySagar 2da086b
chore: tests (all passing)
SoarinSkySagar 25902c6
chore: combine database and storage
SoarinSkySagar eaffc22
feat: fully spec-compliant storage API
SoarinSkySagar 5f1fdb8
chore: privatized Database and removed DatabaseMode
SoarinSkySagar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the database crate from grandine is a bit flawed, I would suggest implementing your own. Specifically, current database impl forces snappy compression for all values - this is inefficient in some cases (e.g., if we save
slot -> state_rootindexes, there is no point of compressing state_root, as it is pure entropy), and not optimal in others (e.g., for blobs you probably want to use something more compressing, like zstd). Thus, forcing single compression algorithm for all values wasn't a good idea. Also, for cases where performance matters, looks like there are currently compression algorithms that are both more performant & give better compression ratios than snappy - like lz4.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, I will be implementing my own database crate on top of this next