-
Notifications
You must be signed in to change notification settings - Fork 129
add mention of caption_entities to filter-queries.md #1212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Why did you add this specific filter query and not one of the 1395 filter queries that are not mentioned on the page? |
|
Same reason others were added - picked randomly.
|
KnorpelSenf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the insane delay, I really don't have enough time for OSS recently. This can still be merged, but I don't fully agree yet:
| bot.on("message:caption_entities:url"); // captions containing a URL | ||
| bot.on("message:entities:code"); // messages containing a code snippet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about this instead?
| bot.on("message:caption_entities:url"); // captions containing a URL | |
| bot.on("message:entities:code"); // messages containing a code snippet | |
| bot.on("message:caption_entities:code"); // captions containing a code snippet |
| | `"message"` | `"message"` | `undefined` | `undefined` | | ||
| | `"message:entities"` | `"message"` | `"entities"` | `undefined` | | ||
| | `"message:entities:mention"` | `"message"` | `"entities"` | `"mention"` | | ||
| | `"message:caption_entities:url"` | `"message"` | `"caption_entities"` | `"url"` | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is inconsistent with the other rows. The point here is to show how a single query is built up in three parts. Adding a second random query is confusing.
Let's revert.
| | `"message:caption_entities:url"` | `"message"` | `"caption_entities"` | `"url"` | |
No description provided.